x/review/git-codereview: allow disabling of "foo.mailed" tag creation

[okdave]

Every time you run "git codereview mail" it creates a new tag (as per its doc).

I've never actually used these tags for their advertised purpose (if I did need to diff against my last mailed commit, I would just use the advertised commit hash from within gerrit), so I don't benefit from them.

OTOH, they do interrupt my workflow. For example, the common git bash completion script prints all pending tags when auto-completing git commit <TAB>, and the sheer number of mailed tags obfuscates any useful information.

So, this is a feature request to disable their automatic creation.

[gopherbot]

CL https://golang.org/cl/36094 mentions this issue.

[ALTree]

@adg (who I suspect owns codereview) Would making tag creation opt-in be too much? (i.e. you'll need to run git mail -tag to create a .mailed tag). We could make tag creation opt-out (like git mail -notag) but I would prefer to have tag creation disabled by default. I've no idea how many people this would annoy, though.

[josharian]

I use the tags, fwiw.

Maybe also support setting default behavior via codereview.cfg, over-rideable by flag?

[ALTree]

Thanks for the feedback. I'll leave the default settings alone, a -notag flag or maybe a .cfg option will be less destructive.

[mvdan]

Hello from the future - I'm still mildly inconvenienced by this :) I guess having the tags around for open CLs is not terrible as there aren't that many of them, but I've accumulated hundreds of these mailed tags, so they're really starting to get in the way.