Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

git-codereview: allow disabling of "foo.mailed" tag creation #15344

Open
okdave opened this issue Apr 18, 2016 · 4 comments

Comments

@okdave
Copy link
Contributor

commented Apr 18, 2016

Every time you run "git codereview mail" it creates a new tag (as per its doc).

I've never actually used these tags for their advertised purpose (if I did need to diff against my last mailed commit, I would just use the advertised commit hash from within gerrit), so I don't benefit from them.

OTOH, they do interrupt my workflow. For example, the common git bash completion script prints all pending tags when auto-completing git commit <TAB>, and the sheer number of mailed tags obfuscates any useful information.

So, this is a feature request to disable their automatic creation.

@bradfitz bradfitz added this to the Unreleased milestone Apr 19, 2016

@gopherbot

This comment has been minimized.

Copy link

commented Feb 2, 2017

CL https://golang.org/cl/36094 mentions this issue.

@ALTree

This comment has been minimized.

Copy link
Member

commented Feb 2, 2017

@adg (who I suspect owns codereview) Would making tag creation opt-in be too much? (i.e. you'll need to run git mail -tag to create a .mailed tag). We could make tag creation opt-out (like git mail -notag) but I would prefer to have tag creation disabled by default. I've no idea how many people this would annoy, though.

@josharian

This comment has been minimized.

Copy link
Contributor

commented Feb 2, 2017

I use the tags, fwiw.

Maybe also support setting default behavior via codereview.cfg, over-rideable by flag?

@ALTree

This comment has been minimized.

Copy link
Member

commented Feb 8, 2017

Thanks for the feedback. I'll leave the default settings alone, a -notag flag or maybe a .cfg option will be less destructive.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
5 participants
You can’t perform that action at this time.