Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

crypto/x509: Wrong error text when failing to unmarshal key-id #15371

Closed
phayes opened this issue Apr 19, 2016 · 2 comments
Closed

crypto/x509: Wrong error text when failing to unmarshal key-id #15371

phayes opened this issue Apr 19, 2016 · 2 comments
Assignees
Milestone

Comments

@phayes
Copy link

@phayes phayes commented Apr 19, 2016

See: https://github.com/golang/go/blob/master/src/crypto/x509/x509.go#L1136

The error returned when unmarshmaling a key-id reads x509: trailing data after X.509 authority key-id. However, this is not the authority-key id, it is the key-id.

Instead it should read x509: trailing data after X.509 key-id

It looks like someone copied and pasted the error from here (https://github.com/golang/go/blob/master/src/crypto/x509/x509.go#L1102) without making the needed change to the text.

@bradfitz bradfitz self-assigned this Apr 19, 2016
@bradfitz bradfitz added this to the Go1.7 milestone Apr 19, 2016
@gopherbot
Copy link

@gopherbot gopherbot commented Apr 19, 2016

CL https://golang.org/cl/22240 mentions this issue.

@gopherbot gopherbot closed this in ba75630 Apr 19, 2016
@golang golang locked and limited conversation to collaborators Apr 19, 2017
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Linked pull requests

Successfully merging a pull request may close this issue.

None yet
3 participants
You can’t perform that action at this time.