Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

x/build: email the author who broke the build #15506

Closed
rakyll opened this issue May 2, 2016 · 3 comments

Comments

Projects
None yet
4 participants
@rakyll
Copy link
Member

commented May 2, 2016

Builders don't email the author of the committer when a build is broken. This results in having broken builds for a long enough time period until someone notices the broken build and notifies the original author. The issue could have been easily improved if a notification email was sent out to the author who last broke build.

/cc @bradfitz @adg

@rakyll rakyll added the Builders label May 2, 2016

@rakyll rakyll added this to the Unreleased milestone May 2, 2016

@ianlancetaylor

This comment has been minimized.

Copy link
Contributor

commented May 2, 2016

We used to do something like this but it was incredibly annoying because the builders are flaky. Perhaps we could start with a check that no similar error occurred in the last 100 builds or so, and only notify if the failure appears to be new.

@ianlancetaylor

This comment has been minimized.

Copy link
Contributor

commented May 2, 2016

Come to think of it, we should also delay any notification until after we've confirmed that the next build fails in the same way.

@bradfitz

This comment has been minimized.

Copy link
Member

commented May 2, 2016

Dup of #12509

@bradfitz bradfitz closed this May 2, 2016

@golang golang locked and limited conversation to collaborators May 2, 2017

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
You can’t perform that action at this time.