Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

database/sql: maxBadConnRetries is hard coded but not configurable #15608

Closed
xiezhenye opened this issue May 9, 2016 · 6 comments
Closed

database/sql: maxBadConnRetries is hard coded but not configurable #15608

xiezhenye opened this issue May 9, 2016 · 6 comments

Comments

@xiezhenye
Copy link

@xiezhenye xiezhenye commented May 9, 2016

In database/sql, maxBadConnRetries is hard coded but not configurable.

Sometimes I do not want it to retry when connect fails, or more retry times is required.

@gopherbot
Copy link

@gopherbot gopherbot commented May 9, 2016

CL https://golang.org/cl/22937 mentions this issue.

@bradfitz bradfitz changed the title In database/sql, maxBadConnRetries is hard coded but not configurable database/sql: maxBadConnRetries is hard coded but not configurable May 9, 2016
@bradfitz bradfitz added this to the Go1.8Maybe milestone May 9, 2016
@gopherbot
Copy link

@gopherbot gopherbot commented May 10, 2016

CL https://golang.org/cl/22965 mentions this issue.

@gopherbot
Copy link

@gopherbot gopherbot commented May 10, 2016

CL https://golang.org/cl/22968 mentions this issue.

xiezhenye added a commit to xiezhenye/go that referenced this issue Jun 29, 2016
… configurable.

Currently, in database/sql, maxBadConnRetries is hard coded but not configurable.

Sometimes I do not want it to retry when connect fails, or more retry times is required.

Fixes golang#15608
@quentinmit quentinmit added the NeedsFix label Oct 10, 2016
@gopherbot
Copy link

@gopherbot gopherbot commented Oct 17, 2016

CL https://golang.org/cl/31140 mentions this issue.

@rsc
Copy link
Contributor

@rsc rsc commented Oct 17, 2016

@xiezhenye, why do you want to configure this? Can you say more about the context in which that makes sense and what behavior you want?

@rsc rsc modified the milestones: Go1.9, Go1.8Maybe Oct 20, 2016
@bradfitz
Copy link
Contributor

@bradfitz bradfitz commented Nov 10, 2016

Timed out. Closing this.

@bradfitz bradfitz closed this Nov 10, 2016
@golang golang locked and limited conversation to collaborators Nov 10, 2017
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Linked pull requests

Successfully merging a pull request may close this issue.

None yet
6 participants
You can’t perform that action at this time.