x/crypto/ssh: No support for Window Dimension Change Message

[johnSchnake]

Please answer these questions before submitting your issue. Thanks!

1. What version of Go are you using (go version)?
   go version go1.6.1 darwin/amd64
2. What operating system and processor architecture are you using (go env)?
   darwin/amd64
3. What did you do?
   If possible, provide a recipe for reproducing the error.
   A complete runnable program is good.
   A link on play.golang.org is best.

Simply a part of the RFC 4254 document that was not implemented; would want a method on an ssh.Session object to send messages such as this.

1. What did you expect to see?
   N/A
2. What did you see instead?
   Not yet implemented.

[johnSchnake]

https://go-review.googlesource.com/#/c/23051/

[hanwen]

there is https://go.googlesource.com/crypto/+/master/ssh/session.go#150 which lets you send this message yourself.

[johnSchnake]

So thanks for pointing that out but could I get some clarification on the design intent as you see it? With exporting that method and the Marshal method, there isn't really a reason to have any of the methods for basic messages (env, signal, pty-req, etc). Since some of them are implemented, it must be some balance between bloat and convenience; I'm just offering up a little bit more convenience for anyone wanting to use this message type.

To utilize those I have to do the exact code I'm submitting here; it seems to me that it just makes sense to do it once in the ssh library rather than in every consumer of the library that otherwise doesn't even have to know about the exact RFC implementation.

[gopherbot]

CL https://golang.org/cl/23051 mentions this issue.