Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

x/crypto/ssh: No support for Window Dimension Change Message #15649

Open
johnSchnake opened this Issue May 11, 2016 · 4 comments

Comments

Projects
None yet
4 participants
@johnSchnake
Copy link

johnSchnake commented May 11, 2016

Please answer these questions before submitting your issue. Thanks!

  1. What version of Go are you using (go version)?
    go version go1.6.1 darwin/amd64
  2. What operating system and processor architecture are you using (go env)?
    darwin/amd64
  3. What did you do?
    If possible, provide a recipe for reproducing the error.
    A complete runnable program is good.
    A link on play.golang.org is best.

Simply a part of the RFC 4254 document that was not implemented; would want a method on an ssh.Session object to send messages such as this.

  1. What did you expect to see?
    N/A
  2. What did you see instead?
    Not yet implemented.

@bradfitz bradfitz added this to the Unreleased milestone May 11, 2016

@johnSchnake

This comment has been minimized.

@hanwen

This comment has been minimized.

Copy link
Contributor

hanwen commented May 11, 2016

there is https://go.googlesource.com/crypto/+/master/ssh/session.go#150 which lets you send this message yourself.

@johnSchnake

This comment has been minimized.

Copy link
Author

johnSchnake commented May 11, 2016

So thanks for pointing that out but could I get some clarification on the design intent as you see it? With exporting that method and the Marshal method, there isn't really a reason to have any of the methods for basic messages (env, signal, pty-req, etc). Since some of them are implemented, it must be some balance between bloat and convenience; I'm just offering up a little bit more convenience for anyone wanting to use this message type.

To utilize those I have to do the exact code I'm submitting here; it seems to me that it just makes sense to do it once in the ssh library rather than in every consumer of the library that otherwise doesn't even have to know about the exact RFC implementation.

@gopherbot

This comment has been minimized.

Copy link

gopherbot commented May 11, 2016

CL https://golang.org/cl/23051 mentions this issue.

@bradfitz bradfitz changed the title golang.org/x/crypto/ssh: No support for Window Dimension Change Message x/crypto/ssh: No support for Window Dimension Change Message Aug 13, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.