Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

net/http: TestTransportEventTrace_h2 fails with "expected substring "WroteRequest: {Err:<nil>}" in output." #15744

mikioh opened this issue May 19, 2016 · 5 comments


Copy link

@mikioh mikioh commented May 19, 2016

Looks like netDial succeeds but httptrace.GotConnInfo is empty, strange.

--- FAIL: TestTransportEventTrace_h2 (0.01s)
    transport_test.go:3305: expected substring "WroteRequest: {Err:<nil>}" in output.
    transport_test.go:3326: Output:
        Getting conn for dns-is-faked.golang:64428 ...
        DNS start: {Host:dns-is-faked.golang}
        DNS done: {Addrs:[{IP: Zone:}] Err:<nil> Coalesced:false}
        ConnectStart: Connecting to tcp ...
        ConnectDone: connected to tcp = <nil>
        got conn: {Conn:<nil> Reused:false WasIdle:false IdleTime:0s}
        got conn: {Conn:0xc4202d8000 Reused:false WasIdle:true IdleTime:2562047h47m16.854775807s}
        first response byte
        first response byte
FAIL    net/http    14.351s
Copy link
Contributor Author

@mikioh mikioh commented May 19, 2016

@mikioh mikioh changed the title net/http: TestTransportEventTrace_h2 fails with empty httptrace.GotConnInfo net/http: TestTransportEventTrace_h2 fails with "expected substring "WroteRequest: {Err:<nil>}" in output." May 19, 2016
@bradfitz bradfitz self-assigned this May 19, 2016
@bradfitz bradfitz added this to the Go1.7 milestone May 19, 2016
Copy link

@bradfitz bradfitz commented May 19, 2016

I have a fix.

Copy link

@gopherbot gopherbot commented May 19, 2016

CL mentions this issue.

Copy link

@gopherbot gopherbot commented May 19, 2016

CL mentions this issue.

gopherbot pushed a commit to golang/net that referenced this issue May 20, 2016
In Go 1.6, the HTTP/1 client got Transport.ExpectContinueTimeout.

This makes the HTTP/2 client respect a Request's "Expect:
100-continue" field and the Transport.ExpectContinueTimeout

This also makes sure to call the traceWroteRequest hook if the server
replied while we're still writing the request, since that code was
in the same spot and it couldn't be trivially separated.

Updates golang/go#13851 (fixed after integrating it into std)
Updates golang/go#15744

Change-Id: I67dfd68532daa6c4a0c026549c6e5cbfce50e1ea
Reviewed-by: Andrew Gerrand <>
@gopherbot gopherbot closed this in 16f846a May 20, 2016
@golang golang locked and limited conversation to collaborators May 20, 2017
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
None yet
Linked pull requests

Successfully merging a pull request may close this issue.

None yet
3 participants