Skip to content

/go

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

net: TestDialTimeoutMaxDuration fails with "Dial didn't return in an expected time" #15745

Closed
mikioh opened this issue May 19, 2016 · 1 comment

Comments

Assignees
No one assigned
Labels
FrozenDueToAge Testing
Projects
None yet
Milestone
  Go1.7Maybe
2 participants
@mikioh @gopherbot
@mikioh
Copy link
Contributor

commented May 19, 2016

For example,

go test -short -count=100 net
--- FAIL: TestDialTimeoutMaxDuration (0.10s)
    timeout_test.go:143: #1: Dial didn't return in an expected time
FAIL
FAIL    net 211.917s

and we see sometimes it happens on buildbots. It just waits 100ms but probably a bit short for some case. Probably extending the deadline by 250ms, which is the maximum wait duration in TestReadTimeoutFluctuation and TestReadFromTimeoutFluctuation, makes sense.

@mikioh mikioh added the Testing label May 19, 2016

@mikioh mikioh added this to the Go1.7Maybe milestone May 19, 2016

@gopherbot

This comment has been minimized.

Sign in to view
Copy link

commented May 19, 2016

CL https://golang.org/cl/23243 mentions this issue.

@gopherbot gopherbot closed this in 9cd2c70 May 20, 2016

@golang golang locked and limited conversation to collaborators May 20, 2017

@gopherbot gopherbot added the FrozenDueToAge label May 20, 2017

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
You can’t perform that action at this time.