net/http: interface-like Transport.Dial being deprecated in favor of concrete *net.Dialer Transport.Dialer

[danp]

In 5855905 the interface-like Transport.Dial was deprecated for a new Transport.Dialer which is a concrete *net.Dialer.

I understand Transport.Dial will remain but as seen in #12737 and #14221 it might be preferable in the long run to use something interface-based. Only DialContext is used on the new Transport.Dialer.

Before this goes out in 1.7 would it be worthwhile to change from a concrete *net.Dialer to either:

• having Transport.Dialer be interface { DialContext(ctx context.Context, network, addr string) }
• keeping only Transport.Dial but using DialContext on it if it implements the above interface?

[danp]

And even while Transport.Dial remains as-is there will be no way for a non-*net.Dialer to receive context since that is only used with Transport.Dialer.

cc @bradfitz

[mikioh]

Ping @bradfitz

[bradfitz]

Sorry, I've been rushing to finish my Go 1.7 bugs before I disappear on vacation for a month. That month begins approximately 15 minutes ago. I'll leave this to others.

[danp]

Happy to submit a CL for this if we can decide on a solution.

[rsc]

It seems like it should be a DialContext func, to match the previous Dial func.

[danp]

Sounds good, I should be able to get a CL together later today.

On Friday, 27 May 2016, Russ Cox notifications@github.com wrote:

It seems like it should be a DialContext func, to match the previous Dial
func.

—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
#15748 (comment), or mute
the thread
https://github.com/notifications/unsubscribe/AAAIhgq7hYZw513BdkG7JSuvvxZqHHgKks5qFn90gaJpZM4IiUoN
.

[rsc]

@dpiddy, I'm heading out soon and want to get this in, so I'll write the CL. I'll make sure you are on it. Thanks.

[gopherbot]

CL https://golang.org/cl/23489 mentions this issue.

[danp]

Thanks!