Skip to content

/ go

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

net/http: make HTTP/1.x handlers able to sent undeclared trailers like HTTP/2 #15754

Closed
bradfitz opened this issue May 19, 2016 · 1 comment
Closed

net/http: make HTTP/1.x handlers able to sent undeclared trailers like HTTP/2 #15754

bradfitz opened this issue May 19, 2016 · 1 comment
Labels
FrozenDueToAge NeedsFix
Milestone
Go1.8

Comments

@bradfitz
Copy link
Contributor

@bradfitz bradfitz commented May 19, 2016

The HTTP/2 server permits setting Trailers mid-Handler without predeclaring them the "Trailer" header by setting "Trailer:Foo" = "Bar". Since a colon isn't allowed in a trailer, that magic prefix is safe.

Do the same for HTTP/1.x. (and thus also in httptest.ResponseRecorder).
@bradfitz bradfitz added this to the Go1.8 milestone May 19, 2016
@quentinmit quentinmit added the NeedsFix label Oct 7, 2016
@gopherbot

This comment has been minimized.

Sign in to view
Copy link

@gopherbot gopherbot commented Nov 1, 2016

CL https://golang.org/cl/32479 mentions this issue.
@gopherbot gopherbot closed this in b2c54af Nov 1, 2016
@golang golang locked and limited conversation to collaborators Nov 1, 2017
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
FrozenDueToAge NeedsFix
Projects
None yet
Milestone
  Go1.8
Linked pull requests

Successfully merging a pull request may close this issue.

None yet
3 participants
@bradfitz @gopherbot @quentinmit
You can’t perform that action at this time.