Skip to content

x/build/cmd/buildlet: detect and kill stray processes #15778

@bradfitz

Description

@bradfitz

The buildlet, especially in reverse buildlet mode, needs to learn how to kill stray processes leftover from previous builds.

(This isn't relevant for VM and container-based builders, since the VM or container kill everything when they exit)

But on OS X and other weirder builders where we run the buildlet in reverse-dialing mode, I sometimes see stray processes. Like this:

Notice testgo spinning:

screen shot 2016-05-20 at 2 32 25 pm

(I think @ianlancetaylor fixed that bug, but still.... we should be tolerant of such bugs in the future)

This is a tracking bug to make the buildlet smarter: enumerate processes at start and end, and kill new things which didn't go away on their own, especially if they're owned or parented by us. Maybe scan the process list often during builds to learn parents, so we know if they were ours or not.

/cc @zombiezen @adg

Metadata

Metadata

Assignees

No one assigned

    Labels

    Buildersx/build issues (builders, bots, dashboards)NeedsFixThe path to resolution is known, but the work has not been done.

    Type

    No type

    Projects

    No projects

    Milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions