Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

x/build/cmd/buildlet: detect and kill stray processes #15778

Open
bradfitz opened this issue May 20, 2016 · 1 comment
Open

x/build/cmd/buildlet: detect and kill stray processes #15778

bradfitz opened this issue May 20, 2016 · 1 comment
Labels
Builders NeedsFix
Milestone

Comments

@bradfitz
Copy link
Contributor

@bradfitz bradfitz commented May 20, 2016

The buildlet, especially in reverse buildlet mode, needs to learn how to kill stray processes leftover from previous builds.

(This isn't relevant for VM and container-based builders, since the VM or container kill everything when they exit)

But on OS X and other weirder builders where we run the buildlet in reverse-dialing mode, I sometimes see stray processes. Like this:

Notice testgo spinning:

screen shot 2016-05-20 at 2 32 25 pm

(I think @ianlancetaylor fixed that bug, but still.... we should be tolerant of such bugs in the future)

This is a tracking bug to make the buildlet smarter: enumerate processes at start and end, and kill new things which didn't go away on their own, especially if they're owned or parented by us. Maybe scan the process list often during builds to learn parents, so we know if they were ours or not.

/cc @zombiezen @adg

@bradfitz bradfitz added Builders NeedsFix labels May 20, 2016
@bradfitz bradfitz added this to the Unreleased milestone May 20, 2016
@bradfitz
Copy link
Contributor Author

@bradfitz bradfitz commented Dec 18, 2018

/cc @dmitshur

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Builders NeedsFix
Projects
None yet
Development

No branches or pull requests

1 participant