Skip to content

cmd/trace,cmd/pprof: should error out when both symbols and binary are missing #15792

@FiloSottile

Description

@FiloSottile

Go 1.7 added the option to generate trace/pprof files with symbols annotations, so the trace help reads:

[pkg.test] argument is required for traces produced by Go 1.6 and below.
Go 1.7 does not require the binary argument.

However, if a trace/pprof generated with Go 1.6 and no binary are supplied to the tool, no error is shown. Instead, the output is simply broken (the profiles are all one empty node, for example).

cmd/trace and cmd/pprof should check if the trace/pprof has annotations, and if not require the binary to be supplied.

Metadata

Metadata

Assignees

No one assigned

    Labels

    FrozenDueToAgeNeedsFixThe path to resolution is known, but the work has not been done.

    Type

    No type

    Projects

    No projects

    Milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions