Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

cmd/trace,cmd/pprof: should error out when both symbols and binary are missing #15792

Closed
FiloSottile opened this issue May 22, 2016 · 4 comments
Closed

Comments

@FiloSottile
Copy link
Member

@FiloSottile FiloSottile commented May 22, 2016

Go 1.7 added the option to generate trace/pprof files with symbols annotations, so the trace help reads:

[pkg.test] argument is required for traces produced by Go 1.6 and below.
Go 1.7 does not require the binary argument.

However, if a trace/pprof generated with Go 1.6 and no binary are supplied to the tool, no error is shown. Instead, the output is simply broken (the profiles are all one empty node, for example).

cmd/trace and cmd/pprof should check if the trace/pprof has annotations, and if not require the binary to be supplied.

@FiloSottile
Copy link
Member Author

@FiloSottile FiloSottile commented May 22, 2016

cc: @dvyukov

@cespare
Copy link
Contributor

@cespare cespare commented May 22, 2016

#10863 tracks this for cmd/pprof already, and a fix (https://golang.org/cl/23323/) was just mailed for that. (Although it only adds a warning; an error might be better.)

@quentinmit quentinmit added this to the Unplanned milestone Jun 17, 2016
@quentinmit quentinmit added the NeedsFix label Jun 17, 2016
@FiloSottile
Copy link
Member Author

@FiloSottile FiloSottile commented Jun 17, 2016

c3818e5 seems to be a fix for cmd/trace

@hyangah
Copy link
Contributor

@hyangah hyangah commented Jan 17, 2018

cmd/trace already addressed this issue.
go uses vendored pprof now so if this fix is still necessary for pprof, let's open an issue in pprof upstream.

@hyangah hyangah closed this Jan 17, 2018
@golang golang locked and limited conversation to collaborators Jan 17, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Linked pull requests

Successfully merging a pull request may close this issue.

None yet
5 participants
You can’t perform that action at this time.