Join GitHub today
GitHub is home to over 50 million developers working together to host and review code, manage projects, and build software together.Sign up
GitHub is where the world builds software
Millions of developers and companies build, ship, and maintain their software on GitHub — the largest and most advanced development platform in the world.
cmd/trace,cmd/pprof: should error out when both symbols and binary are missing #15792
Go 1.7 added the option to generate trace/pprof files with symbols annotations, so the
However, if a trace/pprof generated with Go 1.6 and no binary are supplied to the tool, no error is shown. Instead, the output is simply broken (the profiles are all one empty node, for example).
cmd/trace and cmd/pprof should check if the trace/pprof has annotations, and if not require the binary to be supplied.