Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

cmd/vet: possible bug in code #15883

Closed
dlsniper opened this issue May 29, 2016 · 4 comments
Closed

cmd/vet: possible bug in code #15883

dlsniper opened this issue May 29, 2016 · 4 comments
Milestone

Comments

@dlsniper
Copy link
Contributor

@dlsniper dlsniper commented May 29, 2016

  1. What version of Go are you using (go version)? 1739657
  2. What operating system and processor architecture are you using (go env)? not important
  3. What did you do?

Looking at

indexPending := false
it seems that there's a new variable initialized called indexPending. I believe the correct code should remove that and change the code at
if !indexPending && !state.parseIndex() {
to check for state.indexPending instead of indexPending as it does right now.

  1. What did you expect to see?
    Not sure what that will impact, hopefully nothing.
  2. What did you see instead?
    Either a possible leftover or a possible bug / inconsistency.
@dlsniper

This comment has been minimized.

Copy link
Contributor Author

@dlsniper dlsniper commented May 30, 2016

I will send the CL soon.

@gopherbot

This comment has been minimized.

Copy link

@gopherbot gopherbot commented May 30, 2016

CL https://golang.org/cl/23566 mentions this issue.

@quentinmit quentinmit added this to the Unplanned milestone Jun 17, 2016
@valyala

This comment has been minimized.

Copy link
Contributor

@valyala valyala commented Jun 23, 2016

FYI, The bug will be resolved in #15884 . See the CL, so the issue may be closed now.

@ALTree

This comment has been minimized.

Copy link
Member

@ALTree ALTree commented Jul 18, 2017

Closing, then.

@ALTree ALTree closed this Jul 18, 2017
@golang golang locked and limited conversation to collaborators Jul 18, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Linked pull requests

Successfully merging a pull request may close this issue.

None yet
5 participants
You can’t perform that action at this time.