Skip to content

/go

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

net/http: Serve violates tls.Config immutability promise #15908

Closed
FiloSottile opened this issue May 31, 2016 · 4 comments

Comments

Assignees

@bradfitz bradfitz

Labels
FrozenDueToAge
Projects
None yet
Milestone
  Go1.7Maybe
6 participants
@FiloSottile @tombergan @adg @bradfitz @gopherbot @ianlancetaylor
@FiloSottile
Copy link
Member

commented May 31, 2016

From tls.Confg docs:

After one has been passed to a TLS function it must not be modified.

But calling Serve will call setupHTTP2, which calls http2ConfigureServer, which will modify the tls.Config. Since by the time you call Serve you must have already called tls.Listen, the immutability promise is broken.

I don't think anything relies on it yet, but nothing stops someone from for example caching the NextProtos in crypto/tls.Listen or something, breaking the setupHTTP2 magic.

@FiloSottile FiloSottile referenced this issue May 31, 2016

Closed

x/net/http2: `http.Server.Serve` doesn't serve http2 traffic #14374

@ianlancetaylor ianlancetaylor assigned bradfitz May 31, 2016

@ianlancetaylor ianlancetaylor added this to the Go1.7Maybe milestone May 31, 2016

@tombergan

This comment has been minimized.

Sign in to view
Copy link
Contributor

commented Jun 2, 2016

This might be a dup of Issue #15771
@adg

This comment has been minimized.

Sign in to view
Copy link
Contributor

commented Jun 7, 2016

I'm not sure what, if anything, can be done about this before the 1.7 release.
@bradfitz

This comment has been minimized.

Sign in to view
Copy link
Member

commented Jun 27, 2016

Sent https://golang.org/cl/24508
@gopherbot

This comment has been minimized.

Sign in to view
Copy link

commented Jun 28, 2016

CL https://golang.org/cl/24508 mentions this issue.

@gopherbot gopherbot closed this in b5f0aff Jun 28, 2016

@bradfitz bradfitz referenced this issue Jul 30, 2016

Closed

doc: specify new automatic HTTP/2 behavior of net/http.Server.Serve #16550

gopherbot pushed a commit that referenced this issue Aug 2, 2016

@bradfitz
doc/go1.7.html: mention Server.Serve HTTP/2 behavior change 
Fixes #16550
Updates #15908

Change-Id: Ic951080dbc88f96e4c00cdb3ffe24a5c03079efd
Reviewed-on: https://go-review.googlesource.com/25389
Reviewed-by: Chris Broadfoot <cbro@golang.org>
2629446

@smancke smancke referenced this issue Jan 16, 2017

Closed

Fabio does not serve http2 with go >= 1.7 #215

magiconair added a commit to fabiolb/fabio that referenced this issue Jan 16, 2017

@magiconair
Issue #215: Re-enable HTTP/2 support 
This patch re-enables the HTTP/2 support
for go1.7 and beyond by setting the NextProto
field in the custom TLSConfig.

See golang/go#15908
Unverified
The committer email address is not verified.
Learn about signing commits
Loading status checks…
6a16217

magiconair added a commit to fabiolb/fabio that referenced this issue Jan 16, 2017

@magiconair
Issue #215: Re-enable HTTP/2 support 
This patch re-enables the HTTP/2 support
for go1.7 and beyond by setting the NextProto
field in the custom TLSConfig.

See golang/go#15908
Unverified
The committer email address is not verified.
Learn about signing commits
Loading status checks…
9f2b4ae

magiconair added a commit to fabiolb/fabio that referenced this issue Jan 16, 2017

@magiconair
Issue #215: Re-enable HTTP/2 support 
This patch re-enables the HTTP/2 support
for go1.7 and beyond by setting the NextProto
field in the custom TLSConfig.

See golang/go#15908
Unverified
The committer email address is not verified.
Learn about signing commits
Loading status checks…
425a7a8

magiconair added a commit to fabiolb/fabio that referenced this issue Jan 16, 2017

@magiconair
Issue #215: Re-enable HTTP/2 support 
This patch re-enables the HTTP/2 support
for go1.7 and beyond by setting the NextProto
field in the custom TLSConfig.

See golang/go#15908
Unverified
The committer email address is not verified.
Learn about signing commits
Loading status checks…
056a09e

magiconair added a commit to fabiolb/fabio that referenced this issue Jan 17, 2017

@magiconair
Issue #215: Re-enable HTTP/2 support 
This patch re-enables the HTTP/2 support
for go1.7 and beyond by setting the NextProto
field in the custom TLSConfig.

See golang/go#15908
Unverified
The committer email address is not verified.
Learn about signing commits
Loading status checks…
80ac1c1

magiconair added a commit to fabiolb/fabio that referenced this issue Jan 17, 2017

@magiconair
Issue #215: Re-enable HTTP/2 support 
This patch re-enables the HTTP/2 support
for go1.7 and beyond by setting the NextProto
field in the custom TLSConfig.

See golang/go#15908
Unverified
The committer email address is not verified.
Learn about signing commits
Loading status checks…
92c99b7

@golang golang locked and limited conversation to collaborators Jun 28, 2017

@gopherbot gopherbot added the FrozenDueToAge label Jun 28, 2017

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
You can’t perform that action at this time.