New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

net/http: Serve violates tls.Config immutability promise #15908

Closed

FiloSottile opened this issue May 31, 2016 · 4 comments

Assignees

Labels

FrozenDueToAge

Milestone

Member

FiloSottile commented May 31, 2016

From tls.Confg docs:

After one has been passed to a TLS function it must not be modified.

But calling Serve will call setupHTTP2, which calls http2ConfigureServer, which will modify the tls.Config. Since by the time you call Serve you must have already called tls.Listen, the immutability promise is broken.

I don't think anything relies on it yet, but nothing stops someone from for example caching the NextProtos in crypto/tls.Listen or something, breaking the setupHTTP2 magic.

FiloSottile mentioned this issue

x/net/http2: `http.Server.Serve` doesn't serve http2 traffic #14374

Closed

ianlancetaylor assigned bradfitz

ianlancetaylor added this to the Go1.7Maybe milestone

Contributor

tombergan commented Jun 2, 2016

This might be a dup of Issue #15771

Contributor

adg commented Jun 7, 2016

I'm not sure what, if anything, can be done about this before the 1.7 release.

Contributor

bradfitz commented Jun 27, 2016

Sent https://golang.org/cl/24508

gopherbot commented Jun 28, 2016

CL https://golang.org/cl/24508 mentions this issue.

gopherbot closed this in

b5f0aff

bradfitz mentioned this issue

doc: specify new automatic HTTP/2 behavior of net/http.Server.Serve #16550

Closed

gopherbot pushed a commit that referenced this issue


        doc/go1.7.html: mention Server.Serve HTTP/2 behavior change

Fixes #16550
Updates #15908

Change-Id: Ic951080dbc88f96e4c00cdb3ffe24a5c03079efd
Reviewed-on: https://go-review.googlesource.com/25389
Reviewed-by: Chris Broadfoot <cbro@golang.org>

smancke mentioned this issue

Fabio does not serve http2 with go >= 1.7 #215

Closed

magiconair added a commit to fabiolb/fabio that referenced this issue


        Issue #215: Re-enable HTTP/2 support

6a16217

This patch re-enables the HTTP/2 support
for go1.7 and beyond by setting the NextProto
field in the custom TLSConfig.

See golang/go#15908

magiconair added a commit to fabiolb/fabio that referenced this issue


        Issue #215: Re-enable HTTP/2 support

9f2b4ae

This patch re-enables the HTTP/2 support
for go1.7 and beyond by setting the NextProto
field in the custom TLSConfig.

See golang/go#15908

magiconair added a commit to fabiolb/fabio that referenced this issue


        Issue #215: Re-enable HTTP/2 support

425a7a8

This patch re-enables the HTTP/2 support
for go1.7 and beyond by setting the NextProto
field in the custom TLSConfig.

See golang/go#15908

magiconair added a commit to fabiolb/fabio that referenced this issue


        Issue #215: Re-enable HTTP/2 support

056a09e

This patch re-enables the HTTP/2 support
for go1.7 and beyond by setting the NextProto
field in the custom TLSConfig.

See golang/go#15908

magiconair added a commit to fabiolb/fabio that referenced this issue


        Issue #215: Re-enable HTTP/2 support

80ac1c1

This patch re-enables the HTTP/2 support
for go1.7 and beyond by setting the NextProto
field in the custom TLSConfig.

See golang/go#15908

magiconair added a commit to fabiolb/fabio that referenced this issue


        Issue #215: Re-enable HTTP/2 support

92c99b7

This patch re-enables the HTTP/2 support
for go1.7 and beyond by setting the NextProto
field in the custom TLSConfig.

See golang/go#15908

golang locked and limited conversation to collaborators

gopherbot added the FrozenDueToAge label

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

You can’t perform that action at this time.