Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

cmd/dist: enable misc/cgo/* tests on android/iOS #15919

Open
hyangah opened this issue Jun 1, 2016 · 4 comments
Open

cmd/dist: enable misc/cgo/* tests on android/iOS #15919

hyangah opened this issue Jun 1, 2016 · 4 comments
Milestone
Unreleased

Comments

@hyangah
Copy link
Contributor

hyangah commented Jun 1, 2016

many of cgo tests still remain disabled on android/ios, which prevents from detecting bugs early.
See grep -r android src/cmd/dist/test.go
Re-enable them.
@hyangah hyangah added this to the Unreleased milestone Jun 1, 2016
@gopherbot
Copy link

CL https://golang.org/cl/23634 mentions this issue.

@gopherbot
Copy link

CL https://golang.org/cl/23635 mentions this issue.

gopherbot pushed a commit that referenced this issue Jun 1, 2016
misc/cgo/test,cmd/dist: enable (most) Cgo tests on Android
6de014b 
Some tests cannot build for Android; use build tags and stubs to
skip them.

For #15919

Change-Id: Ieedcb73d4cabe23c3775cfb1d44c1276982dccd9
Reviewed-on: https://go-review.googlesource.com/23634
Run-TryBot: Elias Naur <elias.naur@gmail.com>
TryBot-Result: Gobot Gobot <gobot@golang.org>
Reviewed-by: David Crawshaw <crawshaw@golang.org>
mk0x9 pushed a commit to mk0x9/go that referenced this issue Jun 2, 2016
misc/cgo/test,cmd/dist: enable (more) Cgo tests on iOS
42c51de 
For golang#15919

Change-Id: I9fc38d9c8a9cc9406b551315e1599750fe212d0d
Reviewed-on: https://go-review.googlesource.com/23635
Reviewed-by: David Crawshaw <crawshaw@golang.org>
Run-TryBot: Elias Naur <elias.naur@gmail.com>
TryBot-Result: Gobot Gobot <gobot@golang.org>
@gopherbot
Copy link

Change https://golang.org/cl/163726 mentions this issue: misc/cgo: skip cgotest.TestCrossPackageTests on iOS and set PWD

gopherbot pushed a commit that referenced this issue Feb 26, 2019
@bcmills
misc/cgo: skip cgotest.TestCrossPackageTests on iOS and set PWD
b5a68a9 
I hope that this will fix the tests on iOS, but 'gomote create' isn't
giving me an instance I can test with. (Please patch and test before
approving.)

Updates #15919
Updates #30228

Change-Id: I1b7cd30d5b127a1ad3243b329fa005d229f69a24
Reviewed-on: https://go-review.googlesource.com/c/163726
Run-TryBot: Bryan C. Mills <bcmills@google.com>
TryBot-Result: Gobot Gobot <gobot@golang.org>
Reviewed-by: Elias Naur <mail@eliasnaur.com>
@aclements
Copy link
Member

I recently discovered that some cgo tests appear to be enabled for Android in cmd/dist, but actually do nothing. For example, misc/cgo/stdio and misc/cgo/life are run on Android, but then immediately t.Skip.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
Unreleased
Development

No branches or pull requests
3 participants
@aclements @hyangah @gopherbot