Join GitHub today
GitHub is home to over 36 million developers working together to host and review code, manage projects, and build software together.
Sign upnet/http: Server.ReadTimeout closes connection before response is finished #15929
Comments
ianlancetaylor
changed the title
http.Server.ReadTimeout closes connection before response is finished
net/http: Server.ReadTimeout closes connection before response is finished
Jun 2, 2016
ianlancetaylor
added this to the Unplanned milestone
Jun 2, 2016
ianlancetaylor
assigned
bradfitz
Jun 2, 2016
This comment has been minimized.
This comment has been minimized.
|
We don't start reading the next request until your Handler is done and its output is flushed. Got a demo program showing a repro? Is your ReadTimeout super short? |
bradfitz
added
the
WaitingForInfo
label
Jun 29, 2016
This comment has been minimized.
This comment has been minimized.
|
I'm not able to reproduce it. |
anacrolix
closed this
Jul 7, 2016
anacrolix
added a commit
to anacrolix/archive
that referenced
this issue
Jul 7, 2016
golang
locked and limited conversation to collaborators
Jul 7, 2017
gopherbot
added
the
FrozenDueToAge
label
Jul 7, 2017
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
anacrolix commentedJun 2, 2016
The http.Server.ReadTimeout introduces a timeout for maximum time to consume a request from the wire. However upon completely reading a request, the next request is started, and times out, while the response for the previous request is still being written. This causes the connection to be closed, prematurely closing the ResponseWriter. Closing of the connection should be delayed until the active response is written, or better yet, the ReadTimeout should not begin until the active response is completed (since the connection is not idle).