Join GitHub today
GitHub is home to over 31 million developers working together to host and review code, manage projects, and build software together.Sign up
testing: align package duration values #15944
In the spirit of #10594 I propose that the duration of each package be aligned vertically for ease of comparison and to make sorting by duration a more obvious option:
Maybe I shouldn't be conflating the two but if package duration values are aligned, then people might expect the same for individual tests. One problem with aligning for individual tests is the case of subtests:
If all the times were aligned it would be confusing to sort since the time next to a node in a subtest tree is the cumulative time of all its descendants. You would be including cumulative values with non-cumulative values.
Maybe the gain to package durations is enough of a win that people wouldn't mind the inconsistency between packages and individual tests.
For completeness, I should mention that the 1.10 release includes:
I still think the use case presented by the OP is significant for a human and the new json functionality is kind of heavyweight for just looking around at test performance.
It would still be possible to align the times for each level.
Compatibility with #24929 seems to require that we move the time to the beginning instead of the end, since we won't know the maximum line length until all of the subtests have at least started.