Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

runtime: CgoPprof tests write to $HOME #16121

Closed
mwhudson opened this issue Jun 19, 2016 · 1 comment

Comments

Projects
None yet
3 participants
@mwhudson
Copy link
Contributor

commented Jun 19, 2016

Please answer these questions before submitting your issue. Thanks!

  1. What version of Go are you using (go version)?

1.7 beta 2

  1. What operating system and processor architecture are you using (go env)?

Linux.

  1. What did you do?

Ran the tests under a new-ish version of sbuild, which prevents writing to $HOME by setting it to /sbuild-nonexistent.

  1. What did you expect to see?

The tests pass.

  1. What did you see instead?

They failed like this:

--- FAIL: TestCgoPprof (1.39s)
    crash_cgo_test.go:256: failed to access temp dir /sbuild-nonexistent/pprof: mkdir /sbuild-nonexistent: permission denied
    crash_cgo_test.go:258: exit status 1

There a few ways this could be fixed I guess (only create that directory when it is about to be written into?) but the simplest would I think be to set PPROF_TMPDIR to TMPDIR (or /tmp) in the tests.

@ianlancetaylor ianlancetaylor added this to the Go1.7 milestone Jun 20, 2016

@gopherbot

This comment has been minimized.

Copy link

commented Jun 20, 2016

CL https://golang.org/cl/24270 mentions this issue.

@gopherbot gopherbot closed this in 659b9a1 Jun 21, 2016

@golang golang locked and limited conversation to collaborators Jun 21, 2017

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
You can’t perform that action at this time.