Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

x/text: tests fail with gccgo #16135

Closed
mwhudson opened this issue Jun 21, 2016 · 1 comment
Closed

x/text: tests fail with gccgo #16135

mwhudson opened this issue Jun 21, 2016 · 1 comment

Comments

@mwhudson
Copy link
Contributor

Please answer these questions before submitting your issue. Thanks!

  1. What version of Go are you using (go version)?

gccgo 6 (as shipped in Ubuntu 16.04)

  1. What operating system and processor architecture are you using (go env)?

Ubuntu 16.04 (on amd64)

  1. What did you do?

Run /usr/bin/go-6 test -compiler gccgo golang.org/x/text/...

  1. What did you expect to see?

Tests passing.

  1. What did you see instead?
?       golang.org/x/text   [no test files]
--- FAIL: TestFold (0.00s)
    fold_test.go:32: FullFold(βßᏸ): number of allocs was 1.000000; want 0
    fold_test.go:32: FullFold(abᏼꭺꭰ): number of allocs was 1.000000; want 0
    fold_test.go:32: FullFold(affifflast): number of allocs was 1.000000; want 0
    fold_test.go:32: FullFold(Iİiıͅ): number of allocs was 1.000000; want 0
    fold_test.go:32: FullFold(µµΜΜςσΣΣ): number of allocs was 1.000000; want 0
--- FAIL: TestCaseMappings (0.04s)
    map_test.go:185: 0:und:
        Title: number of allocs was 6.000000; want 0
    map_test.go:185: 1:und:
        Title: number of allocs was 8.000000; want 0
    map_test.go:185: 2:el:
        Upper: number of allocs was 2.000000; want 0
    map_test.go:185: 2:lt:
        Upper: number of allocs was 2.000000; want 0
    map_test.go:185: 3:und:
        Title: number of allocs was 50.000000; want 0
    map_test.go:185: 3:af:
        Title: number of allocs was 50.000000; want 0
    map_test.go:185: 3:az:
        Title: number of allocs was 50.000000; want 0
    map_test.go:185: 3:el:
        Upper: number of allocs was 210.000000; want 0
    map_test.go:185: 3:el:
        Title: number of allocs was 50.000000; want 0
    map_test.go:185: 3:lt:
        Upper: number of allocs was 198.000000; want 0
    map_test.go:185: 3:lt:
        Lower: number of allocs was 22.000000; want 0
    map_test.go:185: 3:lt:
        Title: number of allocs was 111.000000; want 0
    map_test.go:185: 3:nl:
        Title: number of allocs was 50.000000; want 0
    map_test.go:185: 3:tr:
        Title: number of allocs was 50.000000; want 0
    map_test.go:185: 4:und:
        Title: number of allocs was 7.000000; want 0
    map_test.go:185: 5:el:
        Upper: number of allocs was 40.000000; want 0
    map_test.go:185: 5:el:
        Title: number of allocs was 8.000000; want 0
    map_test.go:185: 6:tr:
        Title: number of allocs was 6.000000; want 0
    map_test.go:185: 6:az:
        Title: number of allocs was 6.000000; want 0
    map_test.go:185: 7:lt:
        Upper: number of allocs was 63.000000; want 0
    map_test.go:185: 7:lt:
        Lower: number of allocs was 20.000000; want 0
    map_test.go:185: 7:lt:
        Title: number of allocs was 42.000000; want 0
    map_test.go:185: 8:lt:
        Upper: number of allocs was 15.000000; want 0
    map_test.go:185: 8:lt:
        Lower: number of allocs was 11.000000; want 0
    map_test.go:185: 8:lt:
        Title: number of allocs was 11.000000; want 0
    map_test.go:185: 9:nl:
        Title: number of allocs was 7.000000; want 0
    map_test.go:185: 10:af:
        Title: number of allocs was 3.000000; want 0
FAIL
FAIL    golang.org/x/text/cases 0.815s
ok      golang.org/x/text/collate   0.241s
ok      golang.org/x/text/collate/build 0.129s
--- FAIL: TestNumericWeighterAlloc (0.00s)
    numeric_test.go:155: got 12.000000; want 0
FAIL
FAIL    golang.org/x/text/collate/colltab   3.697s
?       golang.org/x/text/collate/tools/colcmp  [no test files]
ok      golang.org/x/text/currency  5.197s
ok      golang.org/x/text/encoding  0.419s
ok      golang.org/x/text/encoding/charmap  0.158s
ok      golang.org/x/text/encoding/htmlindex    0.164s
ok      golang.org/x/text/encoding/ianaindex    0.133s
?       golang.org/x/text/encoding/internal [no test files]
?       golang.org/x/text/encoding/internal/identifier  [no test files]
ok      golang.org/x/text/encoding/japanese 0.131s
ok      golang.org/x/text/encoding/korean   0.134s
ok      golang.org/x/text/encoding/simplifiedchinese    0.134s
ok      golang.org/x/text/encoding/traditionalchinese   0.162s
ok      golang.org/x/text/encoding/unicode  0.142s
ok      golang.org/x/text/encoding/unicode/utf32    0.152s
ok      golang.org/x/text/internal  0.157s
ok      golang.org/x/text/internal/colltab  0.167s
?       golang.org/x/text/internal/format   [no test files]
?       golang.org/x/text/internal/format/plural    [no test files]
?       golang.org/x/text/internal/gen  [no test files]
ok      golang.org/x/text/internal/number   0.247s
ok      golang.org/x/text/internal/stringset    0.165s
ok      golang.org/x/text/internal/tag  0.134s
?       golang.org/x/text/internal/testtext [no test files]
ok      golang.org/x/text/internal/triegen  1.580s
ok      golang.org/x/text/internal/ucd  0.144s
?       golang.org/x/text/internal/utf8internal [no test files]
--- FAIL: TestMakeString (0.00s)
    language_test.go:73: 4: # allocs got 2.0; want <= 1
    language_test.go:73: 5: # allocs got 2.0; want <= 1
FAIL
FAIL    golang.org/x/text/language  0.451s
ok      golang.org/x/text/language/display  13.581s
ok      golang.org/x/text/message   0.124s
--- FAIL: TestMapAlloc (0.00s)
    runes_test.go:510: got 2.000000; want 0
--- FAIL: TestRemoveAlloc (0.00s)
    runes_test.go:520: got 3.000000; want 0
--- FAIL: TestReplaceIllFormedAlloc (0.00s)
    runes_test.go:528: got 1.000000; want 0
FAIL
FAIL    golang.org/x/text/runes 0.166s
ok      golang.org/x/text/search    0.126s
?       golang.org/x/text/secure    [no test files]
ok      golang.org/x/text/secure/bidirule   0.161s
ok      golang.org/x/text/secure/precis 0.153s
ok      golang.org/x/text/transform 0.238s
?       golang.org/x/text/unicode   [no test files]
ok      golang.org/x/text/unicode/bidi  0.149s
ok      golang.org/x/text/unicode/cldr  0.541s
ok      golang.org/x/text/unicode/norm  15.233s
ok      golang.org/x/text/unicode/rangetable    10.565s
ok      golang.org/x/text/width 0.887s

I think all the failures are for the alloc tests. I guess they should skip on gccgo? (until gccgo gets escape analysis as good or better than gc anyway...)

@quentinmit quentinmit added this to the Unreleased milestone Jun 23, 2016
@mpvl mpvl self-assigned this Jun 28, 2016
@gopherbot
Copy link
Contributor

CL https://golang.org/cl/24495 mentions this issue.

@golang golang locked and limited conversation to collaborators Jul 1, 2017
@rsc rsc unassigned mpvl Jun 23, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

No branches or pull requests

4 participants