text/template: not able to redefine template as an empty string

[evandigby]

Please answer these questions before submitting your issue. Thanks!

1. What version of Go are you using (go version)?

• go version go1.6 linux/amd64
• go version go1.6 darwin/amd64
• go playground

1. What operating system and processor architecture are you using (go env)?

• darwin/amd64
• linux/amd64
• go playground

1. What did you do?

Attempt to redefine a text/template as an empty string using parse, and then executed the template:
https://play.golang.org/p/gotXx8qF3e

1. What did you expect to see?

I expected the template to successfully execute and produce an empty string.

Alternatively, if it is expected behaviour to not allow redefining as an empty string, I expect an error to be returned on the "Parse" call.

1. What did you see instead?

The execute function returned the following error:
template: test: "test" is an incomplete or empty template; defined templates are: "test"

[jessfraz]

dibs

[gopherbot]

CL https://golang.org/cl/24380 mentions this issue.

[dmitshur]

I ran into this as well, and I had a hard time figuring out if this was a bug or intended behavior, because when I tried to find documentation for template redefinition, I couldn't. It seems to be mentioned in passing on https://golang.org/pkg/text/template/#hdr-Actions and nowhere else:

The typical use is to define a set of root templates that are
then customized by redefining the block templates within.

Glad to see it was indeed a bug and is already fixed.

Edit: Actually, what I ran into may be slightly different (but definitely related). I'll have to test to see if it has been fixed by this change on tip.

Edit 2: Not fixed on tip. Filed #16913 for my issue with reproduce steps.

[gopherbot]

CL https://golang.org/cl/38420 mentions this issue.

[gopherbot]

CL https://golang.org/cl/39594 mentions this issue.