cmd/pprof: sync with upstream https://github.com/google/pprof ?

[dgryski]

The pprof tool was initially an import of Google's internal version, which is now on GitHub. Can we just switch to that new repo? Are there patches in Go's copy that need to be pushed upstream to make google/pprof work with current Go binaries?

Maybe this ends up just being a doc fix saying "you can also use this other pprof tool over here".

[hyangah]

I ask @rauls5382 most pprof questions

[rauls5382]

I am not aware of any changes to pprof that are missing on the github version.

There are some UI differences that I plan to smooth out, but other than that it should be fully functional with Go programs. Please open issues at github.com/google/pprof/issues if you encounter any problems.

I think it would be great if we could sync up the two versions at some point.

[bradfitz]

I am not aware of any changes to pprof that are missing on the github version.

Have you been merging all Go's changes? There have been a handful.

[rauls5382]

I have merged a few in the past but admittedly haven't checked recently. I will take a new look.

[quentinmit]

@rauls5382 Have you had a chance to compare-and-merge pprof?

[rauls5382]

I finally spent some time on this. There's about a dozen small CLs that should be upstreamed.
Most of them are very small. I'll be upstreaming them shortly.

[rsc]

@rauls5382, it sounds like you found changes in Go that need to be merged into google/pprof.

What about the other direction? Are there patches in google/pprof that need to be merged into Go?

[rauls5382]

Yes, google/pprof has had many modifications after the golang fork.
There was a significant reorganization of the packages before they were published into golang/pprof. The process of syncing up with upstream will require some manual changes as the package structure is different. I'll put a proposal together.

[quentinmit]

Too late for Go 1.8. Please try to have this ready for Go1.9. Our pprof is falling behind and I would love to have the improvements in Go.