Join GitHub today
GitHub is home to over 50 million developers working together to host and review code, manage projects, and build software together.
Sign upGitHub is where the world builds software
Millions of developers and companies build, ship, and maintain their software on GitHub — the largest and most advanced development platform in the world.
unicode, x/text: unit tests fail on Go1.7 #16234
Closed
Comments
gopherbot
pushed a commit
to golang/text
that referenced
this issue
Jul 1, 2016
Fix tests that would panic if the core Unicode version is ahead of the version used by cases. Issue golang/go#16234 Change-Id: Ica327512629f304d183f28f8fd09c074ebded91c Reviewed-on: https://go-review.googlesource.com/24690 Run-TryBot: Marcel van Lohuizen <mpvl@golang.org> Reviewed-by: Marcel van Lohuizen <mpvl@golang.org>
gopherbot
pushed a commit
to golang/text
that referenced
this issue
Jul 1, 2016
Skip runes that do exist yet in the version of Unicode used in secure/precis, even if they exist in the Unicode version used in core. Issue golang/go#16234 Change-Id: If75ce2b752c3ae0de9cde6937b613d5874149a74 Reviewed-on: https://go-review.googlesource.com/24691 Run-TryBot: Marcel van Lohuizen <mpvl@golang.org> Reviewed-by: Marcel van Lohuizen <mpvl@golang.org>
|
Should be fixed now. Will check in the upgrade to Unicode 9.0.0 for x/text soon after verifying the reverse issue does not exist. |
|
See also #11811 |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
A recent change a2a4db7 causes the following tests to fail:
golang.org/x/text/casesgolang.org/x/text/secure/precisThis is using golang/txt@4440cd4f4c2ea31e1872e00de675a86d0c19006c.
/cc @mpvl