Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

unicode, x/text: unit tests fail on Go1.7 #16234

Closed
dsnet opened this issue Jun 30, 2016 · 2 comments
Closed

unicode, x/text: unit tests fail on Go1.7 #16234

dsnet opened this issue Jun 30, 2016 · 2 comments
Assignees
Milestone

Comments

@dsnet
Copy link
Member

@dsnet dsnet commented Jun 30, 2016

A recent change a2a4db7 causes the following tests to fail:

  • golang.org/x/text/cases
  • golang.org/x/text/secure/precis

This is using golang/txt@4440cd4f4c2ea31e1872e00de675a86d0c19006c.

/cc @mpvl

@dsnet dsnet added this to the Go1.7 milestone Jun 30, 2016
@mpvl mpvl self-assigned this Jul 1, 2016
gopherbot pushed a commit to golang/text that referenced this issue Jul 1, 2016
Fix tests that would panic if the core Unicode version
is ahead of the version used by cases.

Issue golang/go#16234

Change-Id: Ica327512629f304d183f28f8fd09c074ebded91c
Reviewed-on: https://go-review.googlesource.com/24690
Run-TryBot: Marcel van Lohuizen <mpvl@golang.org>
Reviewed-by: Marcel van Lohuizen <mpvl@golang.org>
gopherbot pushed a commit to golang/text that referenced this issue Jul 1, 2016
Skip runes that do exist yet in the version of Unicode
used in secure/precis, even if they exist in the
Unicode version used in core.

Issue golang/go#16234

Change-Id: If75ce2b752c3ae0de9cde6937b613d5874149a74
Reviewed-on: https://go-review.googlesource.com/24691
Run-TryBot: Marcel van Lohuizen <mpvl@golang.org>
Reviewed-by: Marcel van Lohuizen <mpvl@golang.org>
@mpvl
Copy link
Member

@mpvl mpvl commented Jul 1, 2016

Should be fixed now. Will check in the upgrade to Unicode 9.0.0 for x/text soon after verifying the reverse issue does not exist.

@mpvl mpvl closed this Jul 1, 2016
@quentinmit
Copy link
Contributor

@quentinmit quentinmit commented Jul 1, 2016

See also #11811

@golang golang locked and limited conversation to collaborators Jul 2, 2017
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Linked pull requests

Successfully merging a pull request may close this issue.

None yet
4 participants
You can’t perform that action at this time.