Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

time: update tzdata for Go 1.7? #16273

Closed
bradfitz opened this issue Jul 6, 2016 · 6 comments

Comments

Projects
None yet
5 participants
@bradfitz
Copy link
Member

commented Jul 6, 2016

Should we update our bundled tzdata for Go 1.7?

Egypt just changed their DST rules (canceling DST) with 3 days notice:
http://mm.icann.org/pipermail/tz/2016-July/023855.html

https://www.iana.org/time-zones/repository/releases/tzdata2016f.tar.gz was released 2016-07-05

/cc @robpike @adg @ianlancetaylor @quentinmit

@bradfitz bradfitz added this to the Go1.7 milestone Jul 6, 2016

@adg

This comment has been minimized.

Copy link
Contributor

commented Jul 6, 2016

Sounds good to me.

@bradfitz

This comment has been minimized.

Copy link
Member Author

commented Jul 6, 2016

@OneOfOne

This comment has been minimized.

Copy link
Contributor

commented Jul 6, 2016

Off topic, as an Egyptian, YAYAYAYAYAYAYAY.

@gopherbot

This comment has been minimized.

Copy link

commented Jul 6, 2016

CL https://golang.org/cl/24744 mentions this issue.

@bradfitz bradfitz modified the milestones: Go1.7Maybe, Go1.7 Jul 7, 2016

@bradfitz

This comment has been minimized.

Copy link
Member Author

commented Jul 7, 2016

Per comments on the CL, this no longer affects Egypt. (they changed their mind back and forth in-between our releases)

So demoting this to a Maybe.

@ianlancetaylor, your call.

The diff of affected zones is https://gist.github.com/bradfitz/08ad560eaa9790311bd0a168a53c7ca6

Here are the relevant NEWS entries which we'd pull in:

Release 2016f - 2016-07-05 16:26:51 +0200

  Changes affecting future time stamps

    Asia/Novosibirsk switches from +06 to +07 on 2016-07-24 at 02:00.
    (Thanks to Stepan Golosunov.)

  Changes to past and future time stamps

    Asia/Novokuznetsk and Asia/Novosibirsk now use numeric time zone
    abbreviations instead of invented ones.

  Changes affecting past time stamps

    Europe/Minsk's 1992-03-29 spring-forward transition was at 02:00 not 00:00.
    (Thanks to Stepan Golosunov.)


Release 2016e - 2016-06-14 08:46:16 -0700

  Changes affecting past time stamps

    Locations while uninhabited now use '-00', not 'zzz', as a
    placeholder time zone abbreviation.  This is inspired by Internet
    RFC 3339 and is more consistent with numeric time zone
    abbreviations already used elsewhere.  The change affects several
    arctic and antarctic locations, e.g., America/Cambridge_Bay before
    1920 and Antarctica/Troll before 2005.

    Asia/Baku's 1992-09-27 transition from +04 (DST) to +04 (non-DST) was
    at 03:00, not 23:00 the previous day.  (Thanks to Michael Deckers.)
@ianlancetaylor

This comment has been minimized.

Copy link
Contributor

commented Jul 7, 2016

I think we should go ahead and commit your CL.

@gopherbot gopherbot closed this in e5ff529 Jul 7, 2016

@golang golang locked and limited conversation to collaborators Jul 7, 2017

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
You can’t perform that action at this time.