Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

runtime: concurrent map write test doesn't check iterators #16278

Closed
randall77 opened this issue Jul 6, 2016 · 1 comment

Comments

Projects
None yet
2 participants
@randall77
Copy link
Contributor

commented Jul 6, 2016

We now have a best-effort check+fail if a map is concurrently accessed by two goroutines, one of which is a write. (This is a bug in the user's code.) That check is incomplete in the the iterator code path.

Iterators should be considered a read in all circumstances. The check in mapaccessK only happens when iterating during a grow. That check should be moved to mapiternext so it executes for all iterators.

@rsc @josharian

@randall77 randall77 added the NeedsFix label Jul 6, 2016

@randall77 randall77 added this to the Go1.8 milestone Jul 6, 2016

@randall77 randall77 self-assigned this Jul 6, 2016

@gopherbot

This comment has been minimized.

Copy link

commented Jul 6, 2016

CL https://golang.org/cl/24749 mentions this issue.

@gopherbot gopherbot closed this in e492d9f Aug 16, 2016

@golang golang locked and limited conversation to collaborators Aug 16, 2017

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
You can’t perform that action at this time.