Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

crypto/sha256: add AVX/AVX2 implementations of SHA2 #16322

Closed
fkautz opened this issue Jul 11, 2016 · 1 comment
Closed

crypto/sha256: add AVX/AVX2 implementations of SHA2 #16322

fkautz opened this issue Jul 11, 2016 · 1 comment

Comments

@fkautz
Copy link

@fkautz fkautz commented Jul 11, 2016

Golang has a software based SHA2 implementation. Specifically, SHA256 is slower than it needs to be.

With the new upcoming OCI images which bring content-addressable layers which are SHA256 based, it would be very useful to have AVX2 enabled SHA2 sums.


Please answer these questions before submitting your issue. Thanks!

  1. What version of Go are you using (go version)?
    go version go1.6.2 linux/amd64
  2. What operating system and processor architecture are you using (go env)?
    Linux

GOARCH="amd64"
GOBIN=""
GOEXE=""
GOHOSTARCH="amd64"
GOHOSTOS="linux"
GOOS="linux"
GOPATH="/home/fkautz/go"
GORACE=""
GOROOT="/home/fkautz/opt/go"
GOTOOLDIR="/home/fkautz/opt/go/pkg/tool/linux_amd64"
GO15VENDOREXPERIMENT="1"
CC="gcc"
GOGCCFLAGS="-fPIC -m64 -fmessage-length=0"
CXX="g++"
CGO_ENABLED="0"

  1. What did you do?

https://play.golang.org/p/Lg2dgrXJht

  1. What did you expect to see?
    Very fast SHA2 when hardware supports is present
    Normal SHA2 when hardware support is not present
  2. What did you see instead?
    Slower than necessary SHA2
@bradfitz bradfitz changed the title Implement Implement SHA2 in AVX/AVX2 for blazing fast hashes crypto/sha256: add AVX/AVX2 implementations of SHA2 Jul 11, 2016
@bradfitz
Copy link
Contributor

@bradfitz bradfitz commented Jul 11, 2016

This was already done in 2210d88

Loading

@bradfitz bradfitz closed this Jul 11, 2016
@golang golang locked and limited conversation to collaborators Jul 11, 2017
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Linked pull requests

Successfully merging a pull request may close this issue.

None yet
3 participants