Join GitHub today
GitHub is home to over 36 million developers working together to host and review code, manage projects, and build software together.Sign up
runtime: cgocallback signature mismatch #16326
While working on #11041, I encountered the following mismatch:
func cgocallback(fn, frame unsafe.Pointer, framesize uintptr)
The assembly implementation uses the ctxt parameter. However, there are other pure Go callers (in runtime/signal*.go) that call cgocallback directly, which means that there's junk in the ctxt parameter.
It appears that the right fix is to add ctxt to the prototype and add a ctxt parameter to the Go callers. Is this right? What value should ctxt have in those calls? Guidance appreciated.