Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

runtime: revert https://go-review.googlesource.com/18835 on dragonfly 4.4.4 and above #16329

Closed
mikioh opened this issue Jul 12, 2016 · 6 comments

Comments

Projects
None yet
5 participants
@mikioh
Copy link
Contributor

commented Jul 12, 2016

See https://go-review.googlesource.com/c/18835/ and http://gitweb.dragonflybsd.org/dragonfly.git/commit/e5cb2f520ad7ece129e45b29e2b4024e7acfeee6

I've just tested and confirmed that #14067 and friends are fixed on v4.4.3.9.ge5cb2-RELEASE.

@mikioh mikioh added the OS-Dragonfly label Jul 12, 2016

@quentinmit quentinmit added this to the Go1.8 milestone Jul 20, 2016

@quentinmit

This comment has been minimized.

Copy link
Contributor

commented Jul 20, 2016

Can you suggest a way to test if the dragonfly kernel is new enough to have this fix, or would you recommend dropping it entirely?

@bradfitz

This comment has been minimized.

Copy link
Member

commented Jul 20, 2016

Dragonfly users tend to update approximately always.

We got an email saying they'd restarted our builder with this almost immediately too.

@mikioh

This comment has been minimized.

Copy link
Contributor Author

commented Jul 21, 2016

I think it's fine to drop support for DragonFly BSD 4.3 and below from Go 1.8. I guess that typical use cases are an alternative to nginx-on-linux and an alternative to freebsd-on-{many,multi}core machine, so probably the drop of support doesn't matter because the users are pretty familiar with kernel.

PS: Of course we can read out the running kernel version via sysctl system call.

@tdfbsd

This comment has been minimized.

Copy link

commented Aug 9, 2016

The Dragonfly team officially supports the current OS release (4.6 currently) and one prior (4.4), so the answer to someone running 4.3 or earlier would be stay on Go 1.6 or upgrade the OS.

I don't know how frequently most people update Dragonfly, but I personally like to track the master branch simply because I get the latest goodies and historically it has been quite stable.

@gopherbot

This comment has been minimized.

Copy link

commented Sep 21, 2016

CL https://golang.org/cl/29491 mentions this issue.

@gopherbot gopherbot closed this in 5db80c3 Sep 21, 2016

@gopherbot

This comment has been minimized.

Copy link

commented Sep 28, 2016

CL https://golang.org/cl/29971 mentions this issue.

gopherbot pushed a commit that referenced this issue Sep 28, 2016

Mikio Hara
runtime, runtime/cgo: revert CL 18814; don't drop signal stack in new…
… thread on dragonfly

This change reverts CL 18814 which is a workaroud for older DragonFly
BSD kernels, and fixes #13945 and #13947 in a more general way the
same as other platforms except NetBSD.

This is a followup to CL 29491.

Updates #16329.

Change-Id: I771670bc672c827f2b3dbc7fd7417c49897cb991
Reviewed-on: https://go-review.googlesource.com/29971
Run-TryBot: Mikio Hara <mikioh.mikioh@gmail.com>
TryBot-Result: Gobot Gobot <gobot@golang.org>
Reviewed-by: Ian Lance Taylor <iant@golang.org>

@golang golang locked and limited conversation to collaborators Sep 28, 2017

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
You can’t perform that action at this time.