Skip to content

/ go

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

cmd/vet: add s390x support #16373

Closed
josharian opened this issue Jul 14, 2016 · 2 comments
Closed

cmd/vet: add s390x support #16373

josharian opened this issue Jul 14, 2016 · 2 comments
Labels
FrozenDueToAge

Comments

@josharian
Copy link
Contributor

@josharian josharian commented Jul 14, 2016 •
edited

cmd/vet has support for checking assembly. It requires a few details about the architecture. See asmdecl.go. It'd be good to add s390x to it. Unless s390x is very unusual, it should be an easy two-line addition to the block of asmArch* vars.

/cc @billotosyr @mundaym
@mundaym

This comment has been minimized.

Sign in to view
Copy link
Member

@mundaym mundaym commented Jul 14, 2016

This is a duplicate of #15454. The fix is waiting on a test.
@minux minux closed this Jul 14, 2016
@minux

This comment has been minimized.

Sign in to view
Copy link
Member

@minux minux commented Jul 14, 2016

@golang golang locked and limited conversation to collaborators Jul 14, 2017
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
FrozenDueToAge
Projects
None yet
Milestone
No milestone
Linked pull requests

Successfully merging a pull request may close this issue.

None yet
4 participants
@josharian @mundaym @minux @gopherbot
You can’t perform that action at this time.