Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

testing: test.memprofilerate documentation is not accurate #16404

Closed
bradfitz opened this issue Jul 18, 2016 · 1 comment
Closed

testing: test.memprofilerate documentation is not accurate #16404

bradfitz opened this issue Jul 18, 2016 · 1 comment
Labels
Documentation FrozenDueToAge NeedsFix The path to resolution is known, but the work has not been done.
Milestone

Comments

@bradfitz
Copy link
Contributor

bradfitz commented Jul 18, 2016

The docs for the -test.memprofilerate flag say "if >= 0", but the code is simply greater, not greater than or equal:

~/go/src/testing$ git grep memProfileRate
testing.go:     memProfileRate   = flag.Int("test.memprofilerate", 0, "if >=0, sets runtime.MemProfileRate")
testing.go:     if *memProfileRate > 0 {
testing.go:             runtime.MemProfileRate = *memProfileRate

And the default is 512KB, not 0: https://golang.org/pkg/runtime/#pkg-variables

@bradfitz bradfitz changed the title testing: test.memprofilerate document is not accurate testing: test.memprofilerate documentation is not accurate Jul 18, 2016
@quentinmit quentinmit added this to the Go1.8 milestone Jul 20, 2016
@quentinmit quentinmit added the NeedsFix The path to resolution is known, but the work has not been done. label Oct 10, 2016
@gopherbot
Copy link

gopherbot commented Oct 18, 2016

CL https://golang.org/cl/31332 mentions this issue.

@golang golang locked and limited conversation to collaborators Oct 18, 2017
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Documentation FrozenDueToAge NeedsFix The path to resolution is known, but the work has not been done.
Projects
None yet
Development

No branches or pull requests

3 participants