Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Please answer these questions before submitting your issue. Thanks!
go version
go version go1.7rc3 darwin/amd64
go env
GOARCH="amd64" GOBIN="" GOEXE="" GOHOSTARCH="amd64" GOHOSTOS="darwin" GOOS="darwin" GOPATH="/Users/benburkert" GORACE="" GOROOT="/usr/local/Cellar/go/1.7rc3/libexec" GOTOOLDIR="/usr/local/Cellar/go/1.7rc3/libexec/pkg/tool/darwin_amd64" CC="clang" GOGCCFLAGS="-fPIC -m64 -pthread -fno-caret-diagnostics -Qunused-arguments -fmessage-length=0 -fdebug-prefix-map=/var/folders/jl/n78jzg3j6nb8nzbn1vvpg9xc0000gn/T/go-build053329638=/tmp/go-build -gno-record-gcc-switches -fno-common" CXX="clang++" CGO_ENABLED="1"
run this with the race detector: https://play.golang.org/p/9WopZBGsFq
I think the documentation should mention that it is not safe to call Serve with multiple listeners. I have seen this pattern repeated many times for the http & https listeners.
Serve
Data race warning: https://gist.github.com/benburkert/4eb8e7e4acb72984f7568f4e1fdf1847
The text was updated successfully, but these errors were encountered:
This was introduced by http2.
http.Server.http2ConfigureServer can write to s.TLSConfig at the same time as http.Server.shouldConfigureHTTP2ForServe can read it.
http.Server.http2ConfigureServer
s.TLSConfig
http.Server.shouldConfigureHTTP2ForServe
Sorry, something went wrong.
No, it was introduced in b5f0aff which was one month ago. Go 1.6 included http2 and doesn't exhibit this race.
Oh, my bad, sorry.
CL https://golang.org/cl/25280 mentions this issue.
c80e0d3
No branches or pull requests
Please answer these questions before submitting your issue. Thanks!
go version
)?go version go1.7rc3 darwin/amd64
go env
)?If possible, provide a recipe for reproducing the error.
A complete runnable program is good.
A link on play.golang.org is best.
run this with the race detector: https://play.golang.org/p/9WopZBGsFq
I think the documentation should mention that it is not safe to call
Serve
with multiple listeners. I have seen this pattern repeated many times for the http & https listeners.Data race warning: https://gist.github.com/benburkert/4eb8e7e4acb72984f7568f4e1fdf1847
The text was updated successfully, but these errors were encountered: