Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

crypto/x509: re-unify the OS X code paths for loading roots #16508

Closed
bradfitz opened this issue Jul 27, 2016 · 2 comments
Closed

crypto/x509: re-unify the OS X code paths for loading roots #16508

bradfitz opened this issue Jul 27, 2016 · 2 comments

Comments

@bradfitz
Copy link
Contributor

@bradfitz bradfitz commented Jul 27, 2016

This bug is about fixing #16473 properly for Go 1.8.

OS X 10.8 crashes for some reason when loading cert roots using code which works fine from OS X 10.9+.

https://golang.org/cl/25233 + https://golang.org/cl/25281 went in as conservative fixes for Go 1.7, but @hinman has a better patch (https://golang.org/cl/25190) which needed more review and somebody understanding what was happening on OS X 10.8. (see confusion in #16473 (comment) for instance)

@rsc
Copy link
Contributor

@rsc rsc commented Nov 3, 2016

Let's just wait until we can retire OS X 10.8.

@rsc rsc modified the milestones: Unplanned, Go1.8 Nov 3, 2016
@ianlancetaylor
Copy link
Contributor

@ianlancetaylor ianlancetaylor commented Nov 16, 2016

Sounds like there is nothing to do here.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Linked pull requests

Successfully merging a pull request may close this issue.

None yet
6 participants
You can’t perform that action at this time.