Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

os: TestHostname fails if docker container doesn't have /bin/hostname #16536

Closed
meghalidhoble opened this issue Jul 29, 2016 · 3 comments
Closed

os: TestHostname fails if docker container doesn't have /bin/hostname #16536

meghalidhoble opened this issue Jul 29, 2016 · 3 comments

Comments

@meghalidhoble
Copy link

@meghalidhoble meghalidhoble commented Jul 29, 2016

Please answer these questions before submitting your issue. Thanks!

  1. What version of Go are you using (go version)?
    1.6 , using branch release-branch.go1.6
  2. What operating system and processor architecture are you using (go env)?
    Rhel 7.2
  3. What did you do and what's the result?
    The ./all.bash command fails for me inside the docker container with the below error:
    Error : --- FAIL: TestHostname (0.00s)
    os_test.go:1287: fork/exec /bin/hostname: no such file or directory
  4. What did you expect to see?
    All the tests should pass.
  5. My analysis
    I found that the issue I am getting is exactly similar to issue #14693. Hence when I tried applying the patch for this particular issue in my work environment; I found that all the tests were passing.

I would like to know if we can cherry-pick the fix for issue #14693 and merge it into the branch release-branch.go1.6, (which I have done for my environment to verify if it works).
Please note that this commit is not found in the particular branch.

@davecheney

This comment has been minimized.

Copy link
Contributor

@davecheney davecheney commented Jul 29, 2016

I don't think this issue is worth issuing another 1.6 release. This is not a bug with the test, just an artefact that your docker image doesn't have the host name command.

Your go install has built successfully at this time, you can ignore the test failure.

On 29 Jul 2016, at 22:17, meghalidhoble notifications@github.com wrote:

Please answer these questions before submitting your issue. Thanks!

What version of Go are you using (go version)?
1.6 , using branch release-branch.go1.6

What operating system and processor architecture are you using (go env)?
Rhel 7.2

What did you do and what's the result?
The ./all.bash command fails for me inside the docker container with the below error:
Error : --- FAIL: TestHostname (0.00s)
os_test.go:1287: fork/exec /bin/hostname: no such file or directory

What did you expect to see?
All the tests should pass.

My analysis
I found that the issue I am getting is exactly similar to issue #14693. Hence when I tried applying the patch for this particular issue in my work environment; I found that all the tests were passing.

I would like to know if we can cherry-pick the fix for issue #14693 and merge it into the branch release-branch.go1.6, (which I have done for my environment to verify if it works).
Please note that this commit is not found in the particular branch.


You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub, or mute the thread.

@quentinmit quentinmit changed the title Test failing for golang1.6 inside docker on Rhel 7.2 os: TestHostname fails if docker container doesn't have /bin/hostname Jul 29, 2016
@quentinmit

This comment has been minimized.

Copy link
Contributor

@quentinmit quentinmit commented Jul 29, 2016

I agree with @davecheney, 1.7 is about to land and I don't think this merits a 1.6 release.

@quentinmit quentinmit closed this Jul 29, 2016
@meghalidhoble

This comment has been minimized.

Copy link
Author

@meghalidhoble meghalidhoble commented Aug 1, 2016

Thanks @davecheney and @quentinmit for responding, that helped.

@golang golang locked and limited conversation to collaborators Aug 1, 2017
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Linked pull requests

Successfully merging a pull request may close this issue.

None yet
4 participants
You can’t perform that action at this time.