Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

x/build/cmd/release: installer says Win2k requires; download page says XP #16544

Closed
bradfitz opened this issue Jul 29, 2016 · 11 comments
Closed

x/build/cmd/release: installer says Win2k requires; download page says XP #16544

bradfitz opened this issue Jul 29, 2016 · 11 comments
Assignees
Milestone

Comments

@bradfitz
Copy link
Contributor

@bradfitz bradfitz commented Jul 29, 2016

The Wix installer says:

  <Condition Message="Windows 2000 or greater required."> VersionNT >= 500</Condition>                                                                                             

But the golang.org/dl download page says Windows XP+ is required.

@bradfitz bradfitz added the OS-Windows label Jul 29, 2016
@bradfitz bradfitz added this to the Go1.8 milestone Jul 29, 2016
@minux
Copy link
Member

@minux minux commented Jul 30, 2016

@bradfitz bradfitz modified the milestones: Go1.7Maybe, Go1.8 Jul 30, 2016
@bradfitz
Copy link
Contributor Author

@bradfitz bradfitz commented Jul 30, 2016

I'll flag it as a maybe since we might still need to tweak something in that xml file yet anyway. But not critical if we don't do it right away. I think that message only comes up if your Windows is too old anyway.

@alexbrainman
Copy link
Member

@alexbrainman alexbrainman commented Jul 30, 2016

I suggest we change:

 <Condition Message="Windows 2000 or greater required."> VersionNT >= 500</Condition>  

with

 <Condition Message="Windows XP or greater required."> VersionNT >= 500</Condition>  

If someone use this on Windows 2000, good luck to them.

Alex

@bradfitz
Copy link
Contributor Author

@bradfitz bradfitz commented Jul 30, 2016

@alexbrainman, why not also bump the 500 to 501, per https://msdn.microsoft.com/en-us/library/windows/desktop/aa370556(v=vs.85).aspx ?

Specifically, Go requires Windows XP with Service Pack 2 (SP2), IIRC.

If a user really wants to try it on an earlier Windows, they can use the ZIP file instead of the MSI.

@alexbrainman
Copy link
Member

@alexbrainman alexbrainman commented Jul 30, 2016

why not also bump the 500 to 501, per https://msdn.microsoft.com/en-us/library/windows/desktop/aa370556(v=vs.85).aspx ?

I am just trying to change as little as possible. So we don't break some users. I know nothing about MSIs.

If a user really wants to try it on an earlier Windows, they can use the ZIP file instead of the MSI.

Sure. They can use MSI or ZIP file.

Alex

@bradfitz
Copy link
Contributor Author

@bradfitz bradfitz commented Jul 30, 2016

I am just trying to change as little as possible.

For Go 1.7 that sounds fine, just changing the text. I'll keep this bug open for more later.

@gopherbot
Copy link

@gopherbot gopherbot commented Jul 31, 2016

CL https://golang.org/cl/25364 mentions this issue.

gopherbot pushed a commit to golang/build that referenced this issue Jul 31, 2016
Updates golang/go#16544

Change-Id: I96a7a657f2378b86db04f823c6b7a9918e1d502f
Reviewed-on: https://go-review.googlesource.com/25364
Reviewed-by: Alex Brainman <alex.brainman@gmail.com>
@bradfitz bradfitz modified the milestones: Go1.8, Go1.7Maybe Jul 31, 2016
@mkrautz
Copy link
Contributor

@mkrautz mkrautz commented Aug 2, 2016

FYI, CL 25364 only changed the text, but not the NT version.

It now reads:

<Condition Message="Windows XP or greater required."> VersionNT >= 500</Condition>

but it should probably read:

<Condition Message="Windows XP or greater required."> VersionNT >= 501</Condition>

@bradfitz
Copy link
Contributor Author

@bradfitz bradfitz commented Aug 2, 2016

@mkrautz, yup. See #16544 (comment) above. We're being conservative for 1.7.

@mkrautz
Copy link
Contributor

@mkrautz mkrautz commented Aug 2, 2016

Ah, sorry. I came here from the CL, and I didn't read the issue thread. Oops. :-)

@gopherbot
Copy link

@gopherbot gopherbot commented Nov 17, 2016

CL https://golang.org/cl/33354 mentions this issue.

@golang golang locked and limited conversation to collaborators Nov 17, 2017
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Linked pull requests

Successfully merging a pull request may close this issue.

None yet
7 participants
You can’t perform that action at this time.