Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

syscall: delete the "use" func #16607

Closed
ahl opened this issue Aug 4, 2016 · 3 comments
Closed

syscall: delete the "use" func #16607

ahl opened this issue Aug 4, 2016 · 3 comments
Assignees
Milestone

Comments

@ahl
Copy link

@ahl ahl commented Aug 4, 2016

'src/syscall/syscall.go' contains this comment:

// use is a no-op, but the compiler cannot see that it is.
// Calling use(p) ensures that p is kept live until that point.
// This was needed until Go 1.6 to call syscall.Syscall correctly.
// As of Go 1.6 the compiler handles that case automatically.
// The uses and definition of use can be removed early in the Go 1.7 cycle.
//go:noescape
func use(p unsafe.Pointer)

Either this comment should be updated or use should be removed in 1.7 from syscall.go and src/syscall/mksyscall.pl.

Happy to do this work if it's wanted.

@bradfitz bradfitz added this to the Go1.8 milestone Aug 4, 2016
@bradfitz bradfitz changed the title src/syscall/syscall.go has code that should be deleted in 1.7 syscall: delete the "use" func Aug 4, 2016
@bradfitz
Copy link
Contributor

@bradfitz bradfitz commented Aug 4, 2016

Sure, send a CL when the tree opens next week.

@quentinmit quentinmit added the NeedsFix label Oct 10, 2016
@quentinmit quentinmit modified the milestones: Go1.9Early, Go1.8 Oct 13, 2016
@Sajmani Sajmani self-assigned this Feb 8, 2017
@Sajmani
Copy link
Contributor

@Sajmani Sajmani commented Feb 8, 2017

Brad notes that there are also uses of "use" in x/sys/unix.

@gopherbot
Copy link

@gopherbot gopherbot commented Feb 10, 2017

CL https://golang.org/cl/36716 mentions this issue.

@gopherbot gopherbot closed this in 5a303aa Feb 13, 2017
@golang golang locked and limited conversation to collaborators Feb 13, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Linked pull requests

Successfully merging a pull request may close this issue.

None yet
5 participants
You can’t perform that action at this time.