Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

x/tools/cmd/goimports: No longer compiles on go1.4 #16661

Closed
freeformz opened this issue Aug 10, 2016 · 3 comments
Closed

x/tools/cmd/goimports: No longer compiles on go1.4 #16661

freeformz opened this issue Aug 10, 2016 · 3 comments

Comments

@freeformz
Copy link
Contributor

@freeformz freeformz commented Aug 10, 2016

Please answer these questions before submitting your issue. Thanks!

  1. What version of Go are you using (go version)?
    go1.4
  2. What operating system and processor architecture are you using (go env)?
    Linux
  3. What did you do?
$ go get golang.org/x/tools/cmd/goimports
package golang.org/x/tools/cmd/goimports
    imports runtime/trace: unrecognized import path "runtime/trace"
  1. What did you expect to see?
$ $GOPATH/bin/goimports
  1. What did you see instead?
   imports runtime/trace: unrecognized import path "runtime/trace"

Seen here: https://travis-ci.org/lib/pq/jobs/151114204

This is because of golang/tools@edf8e6f

go1.4 isn't actually supported anymore, but people do still use it, that's why lib/pq tests against it.

If there is interest in "fixing" this I can submit a CL, otherwise lib/pq will either have to remove the goimports test and/or stop testing against go1.4

@cespare
Copy link
Contributor

@cespare cespare commented Aug 10, 2016

Dup of #16434

@bradfitz
Copy link
Contributor

@bradfitz bradfitz commented Aug 10, 2016

Dup of #16434

We've decided to not fix it, since we don't test Go 1.4 ourselves at https://build.golang.org/ anymore.

@bradfitz bradfitz closed this Aug 10, 2016
@freeformz
Copy link
Contributor Author

@freeformz freeformz commented Aug 10, 2016

Sorry, I only searched open issues. :-(

@golang golang locked and limited conversation to collaborators Aug 10, 2017
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Linked pull requests

Successfully merging a pull request may close this issue.

None yet
4 participants
You can’t perform that action at this time.