net/http: `dns-should-not-resolve.golang` DNS record found in the `4.2.2.2` DNS server. #16716
Labels
Comments
Considering that the tests are for the continuous builders and developers, and most developers don't tolerate captive portals and lying DNS, I don't think we really need to do anything here. |
I don't think there is anything we can do better either. The choice of the name is good enough -- non existing TLD, long and self documentary SLD. We unfortunately don't have control over every DNS server in the world to make this always pass. Renaming the name to something else doesn't protect us from experiencing the same issue due to the lying DNS servers. |
I'll keep #16732 open at least to at least skip these types of tests during all.bash in short mode, unless you're on a builder. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Building go 1.7 with
all.bash
on osx/amd64, I noticed the following fail in thenet/http
package:I dumped the
httptrace
used in the request that failed and found:Seeing that the DNS was resolving I tested further with nslookup and discovered the DNS server I had been using (4.2.2.2) contained an entry.
Changing the DNS server to a different provider (8.8.8.8) showed no entry.
This error has prevented my
all.bash
tests from passing. I'm not sure if there's a responsibility here to write tests that cannot be spoofed. What is the course to take?The text was updated successfully, but these errors were encountered: