Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

cmd/compile, runtime: need to squeeze StackGuard back down #16792

Closed
dr2chase opened this issue Aug 18, 2016 · 3 comments

Comments

Projects
None yet
5 participants
@dr2chase
Copy link
Contributor

commented Aug 18, 2016

This is for 1.8.

Change in the runtime and changes in the compiler (SSA, and porting) have caused the stack guard to creep up, and it needs to go back down. It's temporarily extra-high because of the PPC port; this is filed to make a note of the problem.

The 3 files that must be changed in sync to modify the StackGuard size are:

src/cmd/internal/obj/stack.go
src/runtime/stack.go
test/nosplit.go

@dr2chase dr2chase self-assigned this Aug 18, 2016

@cherrymui

This comment has been minimized.

Copy link
Contributor

commented Aug 18, 2016

FYI, some history:
long time ago -- 160
9510034 -- increased to 256
b6951bc -- increased to 512
db40624 -- increased to 640
c1b6e39 -- increased to 720

@cespare

This comment has been minimized.

Copy link
Contributor

commented Aug 18, 2016

There's also #9214

@bradfitz

This comment has been minimized.

Copy link
Member

commented Aug 18, 2016

@cespare, thanks. Let's move to the older bug.

@bradfitz bradfitz closed this Aug 18, 2016

@golang golang locked and limited conversation to collaborators Aug 18, 2017

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
You can’t perform that action at this time.