Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

runtime/trace, cmd/trace: include CPU profile samples #16895

Open
rhysh opened this issue Aug 26, 2016 · 1 comment

Comments

@rhysh
Copy link
Contributor

commented Aug 26, 2016

The trace viewer UI provides a mechanism for displaying CPU profile stack samples.

Access to that data inline with other execution trace data—seeing what functions are being executed by goroutines that run for a surprisingly long time—would have been very helpful for diagnosing bugs like #14812, #16293, and #16432. Though the time for those specific bugs may have passed, I think that Go and its users will encounter similar bugs in the future (either in the runtime or in user code).

@quentinmit quentinmit added this to the Go1.8Maybe milestone Sep 6, 2016

@quentinmit quentinmit added the NeedsFix label Oct 11, 2016

@rsc

This comment has been minimized.

Copy link
Contributor

commented Nov 2, 2016

@aclements, this is what confused me!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
4 participants
You can’t perform that action at this time.