Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

x/build: docker image for linux-x86-std-kube Makefile doesn't match coordinator? #16931

Closed
bradfitz opened this issue Aug 30, 2016 · 1 comment

Comments

Projects
None yet
3 participants
@bradfitz
Copy link
Member

commented Aug 30, 2016

@evandbrown, it looks like this CL,

https://go-review.googlesource.com/19021

refactored the Makefile of env/linux-x86-std-kube/Makefile which would've changed its image name from gcr.io/symbolic-datum-552/linux-x86-std:latest to gcr.io/symbolic-datum-552/linux-x86-std-kube:latest but the dashboard/builders.go file was never updated.

One of the two files needs to change so they're in sync.

So far we've just not needed to change anything and have gotten lucky I think.

@bradfitz bradfitz added the Builders label Aug 30, 2016

@bradfitz bradfitz added this to the Unreleased milestone Aug 30, 2016

@bradfitz

This comment has been minimized.

Copy link
Member Author

commented Feb 11, 2017

@bradfitz bradfitz closed this Feb 11, 2017

@golang golang locked and limited conversation to collaborators Feb 11, 2018

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
You can’t perform that action at this time.