Join GitHub today
GitHub is home to over 36 million developers working together to host and review code, manage projects, and build software together.
Sign upx/build: docker image for linux-x86-std-kube Makefile doesn't match coordinator? #16931
Comments
bradfitz
added
the
Builders
label
Aug 30, 2016
bradfitz
added this to the Unreleased milestone
Aug 30, 2016
bradfitz
assigned
evandbrown
Aug 30, 2016
This comment has been minimized.
This comment has been minimized.
|
Was fixed by https://go-review.googlesource.com/28416 |
bradfitz
closed this
Feb 11, 2017
golang
locked and limited conversation to collaborators
Feb 11, 2018
gopherbot
added
the
FrozenDueToAge
label
Feb 11, 2018
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
bradfitz commentedAug 30, 2016
@evandbrown, it looks like this CL,
https://go-review.googlesource.com/19021
refactored the Makefile of
env/linux-x86-std-kube/Makefilewhich would've changed its image name fromgcr.io/symbolic-datum-552/linux-x86-std:latesttogcr.io/symbolic-datum-552/linux-x86-std-kube:latestbut the dashboard/builders.go file was never updated.One of the two files needs to change so they're in sync.
So far we've just not needed to change anything and have gotten lucky I think.