Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

x/build/cmd/release: windows installer propose to remove detected old version in installation directory #16986

Closed
techtonik opened this issue Sep 4, 2016 · 5 comments

Comments

@techtonik
Copy link

@techtonik techtonik commented Sep 4, 2016

What version of Go are you using (go version)?

go1.6.3.windows-386.msi

What operating system and processor architecture are you using (go env)?

set GOROOT=C:\Program Files\Go
set GOTOOLDIR=C:\Program Files\Go\pkg\tool\windows_386
set GO15VENDOREXPERIMENT=1

What did you do?

Run installer go1.6.3.windows-386.msi, it didn't detect existing 1.6.2 installation, so I thought that maybe it is a feature to run multiple versions of Go side by side. Pointed it to existing C:\Program Files\Go installation.

What did you expect to see?

Expected it at least to warn about non-empty directory, then tell me what is he going to do with it:

  1. remove
  2. blend its files inside
  3. fail

What did you see instead?

I see request for administration privileges to continue installation.

@0xmohit
Copy link
Contributor

@0xmohit 0xmohit commented Sep 4, 2016

The current instructions mention:

If you are upgrading from an older version of Go you must first remove the existing version.

@techtonik
Copy link
Author

@techtonik techtonik commented Sep 4, 2016

@0xmohit yea, I saw that, but many open source projects automate this in installer - for example VLC installer detects old installation and proposes several actions:

image

https://github.com/videolan/vlc/tree/master/extras/package/win32

@bradfitz
Copy link
Contributor

@bradfitz bradfitz commented Sep 4, 2016

Related: #16305

We don't have a Windows installer expert on the team. Any help is wanted.

@bradfitz bradfitz changed the title windows installer propose to remove detected old version in installation directory x/build/cmd/release: windows installer propose to remove detected old version in installation directory Sep 4, 2016
@quentinmit quentinmit modified the milestone: Unreleased Sep 6, 2016
@gopherbot gopherbot added the Builders label Mar 21, 2017
@iWdGo
Copy link
Contributor

@iWdGo iWdGo commented Dec 22, 2018

Warning as displayed to install Go 1.12beta1 seems to solve the issue:
go uninstall warning

@bradfitz
Copy link
Contributor

@bradfitz bradfitz commented Dec 22, 2018

Thanks. Will close then.

@bradfitz bradfitz closed this Dec 22, 2018
@golang golang locked and limited conversation to collaborators Dec 22, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Linked pull requests

Successfully merging a pull request may close this issue.

None yet
6 participants
You can’t perform that action at this time.