Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

os: File declaration clean-up #16993

Closed
tortuoise opened this issue Sep 5, 2016 · 1 comment
Closed

os: File declaration clean-up #16993

tortuoise opened this issue Sep 5, 2016 · 1 comment

Comments

@tortuoise
Copy link

@tortuoise tortuoise commented Sep 5, 2016

The os.File type is re-declared across multiple files under src/os for os specific builds.

Can this type declaration be moved into src/os/file.go which currently contains the build-agnostic exported methods ? The declaration can then be removed from all the individual build specific file_xxxx.go ? Will this break anything else ?

If it doesn't break anything, this change will clean up the documentation as well and make it build agnostic because currently some of the type descriptions in the package documentation link to build specific source files, for eg type File links to src/os/file_unix.go

@tortuoise tortuoise changed the title os.File cleanup os.File re-declaration clean-up Sep 5, 2016
@tortuoise tortuoise changed the title os.File re-declaration clean-up os.File declaration clean-up Sep 5, 2016
@minux minux changed the title os.File declaration clean-up os: os.File declaration clean-up Sep 5, 2016
@minux minux changed the title os: os.File declaration clean-up os: File declaration clean-up Sep 5, 2016
@gopherbot

This comment has been minimized.

Copy link

@gopherbot gopherbot commented Sep 5, 2016

CL https://golang.org/cl/28511 mentions this issue.

@gopherbot gopherbot closed this in 5514332 Sep 5, 2016
@golang golang locked and limited conversation to collaborators Sep 5, 2017
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Linked pull requests

Successfully merging a pull request may close this issue.

None yet
2 participants
You can’t perform that action at this time.