Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

cmd/gofmt: Anonymous field could be placed in the 2nd column of a struct #17002

Open
Kroc opened this issue Sep 6, 2016 · 5 comments
Open

cmd/gofmt: Anonymous field could be placed in the 2nd column of a struct #17002

Kroc opened this issue Sep 6, 2016 · 5 comments
Assignees
Milestone

Comments

@Kroc
Copy link

@Kroc Kroc commented Sep 6, 2016

What version of Go are you using (go version)?

go version go1.7 windows/amd64

What operating system and processor architecture are you using (go env)?

set GOARCH=amd64
set GOBIN=
set GOEXE=.exe
set GOHOSTARCH=amd64
set GOHOSTOS=windows
set GOOS=windows
set GOPATH=C:\PROJECTS\Go
set GORACE=
set GOROOT=C:\Go
set GOTOOLDIR=C:\Go\pkg\tool\windows_amd64
set CC=gcc
set GOGCCFLAGS=-m64 -mthreads -fmessage-length=0
set CXX=g++
set CGO_ENABLED=1

What did you do?

gofmt1

What did you expect to see?

gofmt2

What did you see instead?

gofmt1

@quentinmit
Copy link
Contributor

@quentinmit quentinmit commented Sep 6, 2016

I suspect it's being placed in the first column because while it's called an anonymous field, it's actually named rune (as well as being type rune).

@quentinmit quentinmit closed this Sep 6, 2016
@griesemer
Copy link
Contributor

@griesemer griesemer commented Sep 6, 2016

I'm going to re-open this. I think the suggestion is quite reasonable and syntactically it makes sense (but @quentinmit has a point, too). Not saying that I will do anything about it yet, but I want to think about this a bit.

@griesemer griesemer reopened this Sep 6, 2016
@griesemer griesemer self-assigned this Sep 6, 2016
@griesemer griesemer added this to the Unplanned milestone Sep 6, 2016
@Kroc
Copy link
Author

@Kroc Kroc commented Sep 6, 2016

Oh, cool. Thanks. There's a whole variety of ways to look at it, so I can understand opinion on where such a thing should go is going to differ for each person. I see the columns as 'name' and 'type', and so it makes logical sense to me that a name-less field should be lined up that way. The other side of the coin is that a nameless type uses the type as the name; ergo -- it's a name and belongs in the first column.

Last but not least, you can write the type twice as a workaround:

type thing {
    rune    rune    // a character
``
@griesemer
Copy link
Contributor

@griesemer griesemer commented Sep 6, 2016

@Kroc This is not field with a nameless type, it's a field w/o an explicit field name. That is, rune in this case is the type. The work-around that you describe may work here (embedding of a predefined type w/o methods), but generally this is not correct for any type as the semantics of the struct change.

@Kroc
Copy link
Author

@Kroc Kroc commented Sep 6, 2016

Excuse my ignorance, I'm extremely new to Go still :S

@agnivade agnivade changed the title gofmt: Anonymous field could be placed in the 2nd column of a struct cmd/gofmt: Anonymous field could be placed in the 2nd column of a struct Feb 22, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked pull requests

Successfully merging a pull request may close this issue.

None yet
3 participants
You can’t perform that action at this time.