Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

crypto/tls: handshake errors don't send alerts #17037

Closed
FiloSottile opened this issue Sep 9, 2016 · 2 comments
Closed

crypto/tls: handshake errors don't send alerts #17037

FiloSottile opened this issue Sep 9, 2016 · 2 comments
Assignees
Milestone

Comments

@FiloSottile
Copy link
Member

@FiloSottile FiloSottile commented Sep 9, 2016

Since 2a8c81f handshake messages are not written directly to wire but buffered. If an error happens at the wrong time (like at sign time) the alert will be written to the buffer but never flushed, causing an EOF on the client instead of a more descriptive alert.

Fix at https://golang.org/cl/28818/

@bradfitz bradfitz added this to the Go1.8 milestone Sep 9, 2016
@bradfitz

This comment has been minimized.

Copy link
Contributor

@bradfitz bradfitz commented Sep 9, 2016

Assigning to @agl for review.

@gopherbot

This comment has been minimized.

Copy link

@gopherbot gopherbot commented Sep 9, 2016

CL https://golang.org/cl/28818 mentions this issue.

@gopherbot gopherbot closed this in 5a59b66 Sep 11, 2016
FiloSottile added a commit to cloudflare/tls-tris that referenced this issue Sep 14, 2016
Since 2a8c81f handshake messages are not written directly to wire but
buffered.  If an error happens at the wrong time the alert will be
written to the buffer but never flushed, causing an EOF on the client
instead of a more descriptive alert.

Thanks to Brendan McMillion for reporting this.

Fixes golang/go#17037

Change-Id: Ie093648aa3f754f4bc61c2e98c79962005dd6aa2
@golang golang locked and limited conversation to collaborators Sep 11, 2017
FiloSottile added a commit to FiloSottile/go that referenced this issue Oct 12, 2018
Since 2a8c81f handshake messages are not written directly to wire but
buffered.  If an error happens at the wrong time the alert will be
written to the buffer but never flushed, causing an EOF on the client
instead of a more descriptive alert.

Thanks to Brendan McMillion for reporting this.

Fixes golang#17037

Change-Id: Ie093648aa3f754f4bc61c2e98c79962005dd6aa2
Reviewed-on: https://go-review.googlesource.com/28818
Reviewed-by: Adam Langley <agl@golang.org>
Reviewed-by: Brad Fitzpatrick <bradfitz@golang.org>
Run-TryBot: Adam Langley <agl@golang.org>
TryBot-Result: Gobot Gobot <gobot@golang.org>
FiloSottile added a commit to FiloSottile/go that referenced this issue Oct 12, 2018
Since 2a8c81f handshake messages are not written directly to wire but
buffered.  If an error happens at the wrong time the alert will be
written to the buffer but never flushed, causing an EOF on the client
instead of a more descriptive alert.

Thanks to Brendan McMillion for reporting this.

Fixes golang#17037

Change-Id: Ie093648aa3f754f4bc61c2e98c79962005dd6aa2
Reviewed-on: https://go-review.googlesource.com/28818
Reviewed-by: Adam Langley <agl@golang.org>
Reviewed-by: Brad Fitzpatrick <bradfitz@golang.org>
Run-TryBot: Adam Langley <agl@golang.org>
TryBot-Result: Gobot Gobot <gobot@golang.org>
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Linked pull requests

Successfully merging a pull request may close this issue.

None yet
4 participants
You can’t perform that action at this time.