Join GitHub today
GitHub is home to over 40 million developers working together to host and review code, manage projects, and build software together.Sign up
At least on the builder, it tickles gold the wrong way:
Odd, as the plugin mode mostly depends on linker configuration used by either c-shared or shared.
Mysterious error and no time or easy machine access to investigate now, so disabling the -buildmode=plugin test on arm64. (The arm version is working as expected.) Updates #17138 Change-Id: I4cc56ddf47e7597213462e48d4934a765168bd07 Reviewed-on: https://go-review.googlesource.com/29363 Reviewed-by: Brad Fitzpatrick <firstname.lastname@example.org>
With CL https://go-review.googlesource.com/c/go/+/109917, testplugin passes locally. It still fails on the builder with an internal error in gold.
Seems the gold linker on the builder is rather old:
On the machine where the test passes:
I wonder, could we update gold on the builder, and require a newer gold for using plugin on linux/arm64? cc @bradfitz
The init function and runtime.addmoduledata were not added when building plugin, which caused the runtime could not find the module. Testplugin is still not enabled on linux/arm64 (https://go.googlesource.com/go/+/master/src/cmd/dist/test.go#948) because the gold linker on the builder is too old, which fails with an internal error (see issue #17138). I tested locally and it passes. Fixes #24940. Updates #17138. Change-Id: I26aebca6c38a3443af0949471fa12b6d550e8c6c Reviewed-on: https://go-review.googlesource.com/109917 Run-TryBot: Cherry Zhang <email@example.com> Reviewed-by: Ian Lance Taylor <firstname.lastname@example.org>