Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

cmd/vet: accept space-separated tag list, like cmd/go #17148

Closed
yaojingguo opened this issue Sep 18, 2016 · 3 comments
Closed

cmd/vet: accept space-separated tag list, like cmd/go #17148

yaojingguo opened this issue Sep 18, 2016 · 3 comments

Comments

@yaojingguo
Copy link
Contributor

@yaojingguo yaojingguo commented Sep 18, 2016

Please answer these questions before submitting your issue. Thanks!

What version of Go are you using (go version)?

go version go1.7.1 linux/amd64

Now different go cmds handle tag list in different ways:

  • go build , go test and go vet accepts space-separated tag list.
  • go tool vet accepts comma-separated tag list. go tool vet -h says:
  -tags string
        comma-separated list of build tags to apply when parsing

If these cmds handle tag list in a consistent way, it will be easier for users to use them.

@quentinmit

This comment has been minimized.

Copy link
Contributor

@quentinmit quentinmit commented Oct 3, 2016

This probably means we need to accept both comma and space separated lists to avoid breaking any existing callers.

@rakyll rakyll changed the title cmd: inconsistent handing of tag list cmd/go: inconsistent handing of tag list Oct 20, 2016
@rsc

This comment has been minimized.

Copy link
Contributor

@rsc rsc commented Oct 20, 2016

go tool vet added its tag list much more recently than the others. I think we can change vet to take spaces too, but we're not going to change the go command proper to start taking commas.

@rsc rsc modified the milestones: Go1.8, Go1.8Maybe Oct 20, 2016
@rsc rsc changed the title cmd/go: inconsistent handing of tag list cmd/vet: accept space-separated tag list, like cmd/go Oct 20, 2016
@gopherbot

This comment has been minimized.

Copy link

@gopherbot gopherbot commented Oct 25, 2016

CL https://golang.org/cl/32030 mentions this issue.

@gopherbot gopherbot closed this in a850dbd Oct 25, 2016
@golang golang locked and limited conversation to collaborators Oct 25, 2017
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Linked pull requests

Successfully merging a pull request may close this issue.

None yet
4 participants
You can’t perform that action at this time.