Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

x/text/unicode/bidi: Support changes to Bidi algorithm in Unicode 8.0 #17189

Closed
deepakjois opened this issue Sep 22, 2016 · 3 comments
Closed

x/text/unicode/bidi: Support changes to Bidi algorithm in Unicode 8.0 #17189

deepakjois opened this issue Sep 22, 2016 · 3 comments

Comments

@deepakjois
Copy link

@deepakjois deepakjois commented Sep 22, 2016

Here is a change to support updates to the Bidi algorithm in Unicode 8.0:
https://go-review.googlesource.com/c/29630/

@mpvl, I guess you are the right person to look at this?

I am the author of luabidi. I initially referred the Go implementation along with the reference Java implementation to write a line by line port of the reference code to Lua. However, both the Go version and the Java reference version do not support the changes to the algorithm made in Unicode 8.0.

I looked at the changes in the C reference implementation, and then modified my Lua version, as well as the Java reference version. Finally, I decided to port the implementation to Go as well, just to get some more confidence. These changes have been tested pretty thoroughly both in Lua and in the (updated) Java reference implementation.

I had to make a minor change to the test file to get the tests to pass. But I believe, that change should have been there in the first place, if we go by the Java reference version.

@mpvl
Copy link
Contributor

@mpvl mpvl commented Sep 22, 2016

Hi Deepak,

Thanks for your contribution! That is very useful. Will take a look now.

Note that the reference implementation is not yet hooked up to the API,
which is still on the TODO list. But if you intend to use it let me know.

Thanks,

Marcel

On Thu, Sep 22, 2016 at 8:53 AM, Deepak Jois notifications@github.com
wrote:

Here is a change to support updates to the Bidi algorithm in Unicode 8.0:
https://go-review.googlesource.com/c/29630/

@mpvl https://github.com/mpvl, I guess you are the right person to look
at this?

I am the author of luabidi https://github.com/deepakjois/luabidi. I
initially referred the Go implementation along with the reference Java
implementation to write a line by line port of the reference code to Lua.
However, both the Go version and the Java reference version do not support
the changes to the algorithm made in Unicode 8.0.

I looked at the changes in the C version, and then modified my Lua
version, as well as the Java reference version
https://github.com/deepakjois/BidiReferenceJava. Finally, I decided to
port the implementation to Go as well, just to get some more confidence.
These changes have been tested pretty thoroughly both in Lua and in the
Java reference implementation.

I had to make a minor change to the test file to get the tests to pass.
But I believe, that change should have been there in the first place, if we
go by the Java reference version.


You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
#17189, or mute the thread
https://github.com/notifications/unsubscribe-auth/AGJZR_fjq9AkK7IrK1T8u04f2DpjNtxvks5qsiXSgaJpZM4KDlBL
.

@deepakjois
Copy link
Author

@deepakjois deepakjois commented Sep 22, 2016

I read in the comments that it needs a Segmenter interface, which would be nice.

I have no immediate use for it, but I do plan to use this BiDi implementation sometime in the future for a text processing package I have plans to work on. No idea if and when that will happen. So I guess you can take your time.

@quentinmit quentinmit added this to the Unreleased milestone Oct 4, 2016
@quentinmit quentinmit added this to the Unreleased milestone Oct 4, 2016
@mpvl
Copy link
Contributor

@mpvl mpvl commented Oct 12, 2016

The CL was merged

@mpvl mpvl closed this as completed Oct 12, 2016
@golang golang locked and limited conversation to collaborators Oct 12, 2017
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

No branches or pull requests

4 participants