Repository navigation
proposal: testing: Export Name of Test or Benchmark #17231
Description
What version of Go are you using (go version)?
1.7
What operating system and processor architecture are you using (go env)?
windows/amd64
What did you do?
Can't get a test name without using reflection or hard-coding name.
Test name is not exported https://github.com/golang/go/blob/master/src/testing/testing.go#L269.
What did you expect to see?
The test name exported.
e.g.
func TestSomething(t *testing.T) {
t.Log(t.Name())
...
}
What did you see instead?
Non-exported test name.
Activity
minux commentedon Sep 26, 2016
adg commentedon Sep 26, 2016
This makes sense, but what's your use case?
minux commentedon Sep 27, 2016
sgerhardt commentedon Sep 27, 2016
My use cases are simple. I want to know what test is running when I pass test functions to utility functions, and/or want to log the name of a test for recording to external services.
adg commentedon Sep 27, 2016
Ok, sounds good to me. Please write up a brief proposal document.
seangerhardt-wf commentedon Sep 28, 2016
@adg Did you want a design document? As far as proposals go, it looks like this issue should be enough if I've understood the directions correctly.
The change should be very simple - don't feel like a design document is really necessary, but let me know.
Thanks,
Sean
adg commentedon Sep 28, 2016
Well, just spec out here what the method looks like.
On 28 September 2016 at 10:35, Sean Gerhardt notifications@github.com
wrote:
sgerhardt commentedon Sep 28, 2016
I was thinking we could export the field. https://github.com/golang/go/blob/master/src/testing/testing.go#L269 change
nametoNamee.g.
Name string // Name of test or benchmark.adg commentedon Sep 28, 2016
I'd be wary of doing that, lest people change the Name in a test.
Safer would be to add a
Name() stringmethod to*testing.Tand*testing.B, I think.Care to send a CL?
sgerhardt commentedon Sep 28, 2016
That does sound like a safer approach. What's a CL?
adg commentedon Sep 28, 2016
A "change list" (see the contribution docs). But this is so simple that I'll do it, to save you the trouble of setting up a dev environment.
gopherbot commentedon Sep 28, 2016
CL https://golang.org/cl/29970 mentions this issue.