Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

x/crypto/acme: provide mock implementation for tests #17251

Open
rogpeppe opened this issue Sep 27, 2016 · 4 comments
Open

x/crypto/acme: provide mock implementation for tests #17251

rogpeppe opened this issue Sep 27, 2016 · 4 comments
Milestone

Comments

@rogpeppe
Copy link
Contributor

@rogpeppe rogpeppe commented Sep 27, 2016

Without faking out the whole of GetCertificate, it's not easy
to test an autocert-based system, and doing things that way
leaves substantial room for getting the Manager configuration
wrong.

The autocert tests contain an ACME CA server stub - maybe that
could be made available publicly in some form.

@quentinmit quentinmit modified the milestone: Unreleased Oct 4, 2016
@gopherbot

This comment has been minimized.

Copy link

@gopherbot gopherbot commented May 2, 2017

CL https://golang.org/cl/41731 mentions this issue.

@x1ddos

This comment has been minimized.

Copy link

@x1ddos x1ddos commented May 2, 2017

Sorry that was wrong CL. But I'm definitely planning on fixing this one, too.

@x1ddos

This comment has been minimized.

Copy link

@x1ddos x1ddos commented Jul 19, 2017

There's now https://github.com/letsencrypt/pebble, which is testing-oriented set of packages/mini implementation of the upcoming Let's Encrypt v2 endpoint. Might be useful.

@gopherbot

This comment has been minimized.

Copy link

@gopherbot gopherbot commented Jul 23, 2018

Change https://golang.org/cl/125495 mentions this issue: acme/autocert: add support for tls-alpn-01

gopherbot pushed a commit to golang/crypto that referenced this issue Jul 23, 2018
Because tls.Config now requires more fields to be set
in order for tls-alpn to work, Manager provides a new
TLSConfig method for easier setup.

This CL also adds a new internal package for end-to-end tests.
The package implements a simple ACME CA server.

Fixes golang/go#25013
Fixes golang/go#25901
Updates golang/go#17251

Change-Id: I2687ea8d5c445ddafad5ea2cdd36cd4e7d10bc86
Reviewed-on: https://go-review.googlesource.com/125495
Reviewed-by: Brad Fitzpatrick <bradfitz@golang.org>
Run-TryBot: Brad Fitzpatrick <bradfitz@golang.org>
TryBot-Result: Gobot Gobot <gobot@golang.org>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked pull requests

Successfully merging a pull request may close this issue.

None yet
4 participants
You can’t perform that action at this time.