Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

time: TestLoadFixed failure #17276

Closed
ALTree opened this issue Sep 29, 2016 · 19 comments

Comments

Projects
None yet
8 participants
@ALTree
Copy link
Member

commented Sep 29, 2016

What version of Go are you using (go version)?

$ gotip version
go version devel +847bc6d Thu Sep 29 10:56:03 2016 +0200 linux/amd64
$ uname -a
Linux [...] 4.6.0-1-amd64 #1 SMP Debian 4.6.4-1 (2016-07-18) x86_64 GNU/Linux

What operating system and processor architecture are you using (go env)?

GOARCH="amd64"
GOBIN=""
GOEXE=""
GOHOSTARCH="amd64"
GOHOSTOS="linux"
GOOS="linux"
GOPATH="/home/[...]/gocode"
GORACE=""
GOROOT="/home/[...]/go"
GOTOOLDIR="/home/[...]/go/pkg/tool/linux_amd64"
CC="gcc"
GOGCCFLAGS="-fPIC -m64 -pthread -fmessage-length=0 -fdebug-prefix-map=/tmp/go-build162033413=/tmp/go-build -gno-record-gcc-switches"
CXX="g++"
CGO_ENABLED="1"

What did you do?

$ cd src/time
$ gotip test -run=TestLoadFixed

What did you see?

--- FAIL: TestLoadFixed (0.00s)
    time_test.go:947: Now().In(loc).Zone() = "-01", -3600, want "GMT+1", -3600
FAIL
exit status 1
FAIL    time    0.003s
@ALTree

This comment has been minimized.

Copy link
Member Author

commented Sep 29, 2016

A new version of tzdata, (tzdata-2016g), was released yesterday. From the changelog:

Several zones in Antarctica and the former Soviet Union, along
with zones intended for ships at sea that cannot use POSIX TZ
strings, now use numeric time zone abbreviations instead of
invented or obsolete alphanumeric abbreviations. The affected
zones are [...] Etc/GMT+1 [...]

Etc/GMT+1 is exactly the zone parsed in the failing test.

@ALTree

This comment has been minimized.

Copy link
Member Author

commented Sep 29, 2016

Cooking up a patch.

@ALTree

This comment has been minimized.

Copy link
Member Author

commented Sep 29, 2016

@lfam

This comment has been minimized.

Copy link

commented Oct 21, 2016

Applying the fix in c5434f2 to Go 1.4.3 (which can be used as a Go bootstrap compiler) does not work. It fails like this:

# Building C bootstrap tool.
cmd/dist

# Building compilers and Go bootstrap tool for host, linux/amd64.
lib9
go tool dist: missing file /tmp/guix-build-go-1.4.3.drv-0/go/include/fmt.h

Any advice?

@ianlancetaylor

This comment has been minimized.

Copy link
Contributor

commented Oct 21, 2016

This issue is closed and the bug you are reporting is not related to it. Please ask on a forum instead; see https://golang.org/wiki/Questions . Thanks.

@banditsmile

This comment has been minimized.

Copy link

commented Oct 22, 2016

use go1.4.3 binary package on ubuntu16.04 to build go1.7.3 still face this time package failed problem

@ianlancetaylor

This comment has been minimized.

Copy link
Contributor

commented Oct 22, 2016

@banditsmile This issue is closed. It is not expected to be fixed in 1.4.3 or 1.7.3. If you want to make a case to backport the change to an older release, please open a new issue. Thanks.

unclejack added a commit to unclejack/go that referenced this issue Oct 24, 2016

time: update test for tzdata-2016g
Fixes golang#17276

Change-Id: I0188cf9bc5fdb48c71ad929cc54206d03e0b96e4
Reviewed-on: https://go-review.googlesource.com/29995
Reviewed-by: Brad Fitzpatrick <bradfitz@golang.org>
Run-TryBot: Brad Fitzpatrick <bradfitz@golang.org>
TryBot-Result: Gobot Gobot <gobot@golang.org>

ceseo added a commit to powertechpreview/go that referenced this issue Oct 26, 2016

time: update test for tzdata-2016g
Fixes golang#17276

Change-Id: I0188cf9bc5fdb48c71ad929cc54206d03e0b96e4
Reviewed-on: https://go-review.googlesource.com/29995
Reviewed-by: Brad Fitzpatrick <bradfitz@golang.org>
Run-TryBot: Brad Fitzpatrick <bradfitz@golang.org>
TryBot-Result: Gobot Gobot <gobot@golang.org>
@gopherbot

This comment has been minimized.

Copy link

commented Nov 16, 2016

CL https://golang.org/cl/33308 mentions this issue.

ceseo added a commit to powertechpreview/go that referenced this issue Dec 1, 2016

time: update test for tzdata-2016g
Fixes golang#17276

Change-Id: I0188cf9bc5fdb48c71ad929cc54206d03e0b96e4
Reviewed-on: https://go-review.googlesource.com/29995
Reviewed-by: Brad Fitzpatrick <bradfitz@golang.org>
Run-TryBot: Brad Fitzpatrick <bradfitz@golang.org>
TryBot-Result: Gobot Gobot <gobot@golang.org>
@gdsotirov

This comment has been minimized.

Copy link

commented Dec 2, 2016

The fix from c5434f2 is still not included in just released 1.7.4 and I cannot understand why. I have to manually apply the patch.

@minux

This comment has been minimized.

Copy link
Member

commented Dec 2, 2016

@ALTree

This comment has been minimized.

Copy link
Member Author

commented Dec 2, 2016

To be fair, the last time this happened the patch was actually cherry-picked in the following minor release.

See: milestone 1.3.3, the issue #8814 was fixes on tip (to be 1.4), but the patch was also included in 1.3.3.

tzdata test failures are harmless, but also pretty annoying because as soon as the major OSes receive the updated timezones data, all.bash will always fail on all architectures and on all systems, for all users.

@minux

This comment has been minimized.

Copy link
Member

commented Dec 2, 2016

@ALTree

This comment has been minimized.

Copy link
Member Author

commented Dec 2, 2016

Ah, thanks. This is the part I missed:

The only code changes included in the release are the fixes for the specific critical problems

I was convinced it was something like "issued for serious problems, but then it's fine to cherry-pick other small stuff".

@gdsotirov

This comment has been minimized.

Copy link

commented Dec 2, 2016

@minux I haven't omitted the fact that 1.7.4 is a minor security release (there were clear announcements), but still I think cherry picking some other small changes like c5434f2 is worth it. Otherwise, packages like me would have to apply patches as normally most Linux distributions moved tzdata to newer than 2016g and thus it is annoying as @ALTree wrote. Anyway, we'll all have to wait for 1.7.5, 1.8 or whatever else release that includes c5434f2 when it's fully tested (I confirm it's well working on Slackware 14.2).

@minux

This comment has been minimized.

Copy link
Member

commented Dec 2, 2016

@gdsotirov

This comment has been minimized.

Copy link

commented Dec 2, 2016

@minux By no way I'm questioning Go's release cycle, but to me it appears too harsh if such small but useful fixes like c5434f2, which help keep Go aligned with the OS updates, are dropped completely from minor releases. And as a distribution packager I'd like to ask what is my workaround for the the time test failure then? I either have to suppress tests completely or I have to manage and apply patches, which as I already wrote is annoying especially for software under active development. Again, I accept Go members' position, but still I'd like express my dissatisfaction. Hopefully, Go 1.8 should be released in a month or so according to the beta1 announcement.

@bradfitz

This comment has been minimized.

Copy link
Member

commented Dec 2, 2016

@gdsotirov, yeah, that's a bit unfortunate. I filed #18163.

@gopherbot

This comment has been minimized.

Copy link

commented Dec 6, 2016

CL https://golang.org/cl/34050 mentions this issue.

mbland added a commit to mbland/gvm that referenced this issue Dec 12, 2016

Add patches for TestLoadFixed issue for 1.4-1.7
See: golang/go#17276

Granted, gvm doesn't normally run the tests, but I like to run them to
ensure a build is healthy:

  $ gvm install <some-version>
  $ gvm use <some-version>
  $ go tool dist test -no-rebuild

(Hey, maybe this test step could become a future `gvm install` option?)

Also per golang/go#18163, test fixes may
eventually be permitted for security point releases, at which point
patches like these can possibly go away (since the fix would then be to
use a later point release on affected platforms).
@gopherbot

This comment has been minimized.

Copy link

commented Jan 24, 2017

CL https://golang.org/cl/35635 mentions this issue.

gopherbot pushed a commit that referenced this issue Jan 25, 2017

[release-branch.go1.7] time: update test for tzdata-2016g
Backport of the fix to #17276 for Go 1.7.

Change-Id: Ifc1a8e2a81d4e543dbef04566985618884a8c0e0
Reviewed-on: https://go-review.googlesource.com/35635
Run-TryBot: Brad Fitzpatrick <bradfitz@golang.org>
Reviewed-by: Joe Tsai <thebrokentoaster@gmail.com>
Reviewed-by: Alberto Donizetti <alb.donizetti@gmail.com>
TryBot-Result: Gobot Gobot <gobot@golang.org>

@golang golang locked and limited conversation to collaborators Jan 24, 2018

metux added a commit to oss-qm/go that referenced this issue Nov 8, 2018

time: update test for tzdata-2016g
Fixes golang#17276

Change-Id: I0188cf9bc5fdb48c71ad929cc54206d03e0b96e4
Reviewed-on: https://go-review.googlesource.com/29995
Reviewed-by: Brad Fitzpatrick <bradfitz@golang.org>
Run-TryBot: Brad Fitzpatrick <bradfitz@golang.org>
TryBot-Result: Gobot Gobot <gobot@golang.org>
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
You can’t perform that action at this time.