x/net/http2: pre-1.7 broken build #17286
Closed
Labels
Comments
This just started happening to me about 12 hours ago for no reason, on Go 1.7 !!! |
CL https://golang.org/cl/30070 mentions this issue. |
c3mb0
pushed a commit
to c3mb0/net
that referenced
this issue
Apr 2, 2018
https://golang.org/cl/29965 adding ClientConn.Ping support introduced a build failure on Go versions before 1.7. Fixes golang/go#17286 Change-Id: Ibfb565e7d823a436e58dc833973d7bdb41b7de5a Reviewed-on: https://go-review.googlesource.com/30071 Run-TryBot: Brad Fitzpatrick <bradfitz@golang.org> TryBot-Result: Gobot Gobot <gobot@golang.org> Reviewed-by: Joe Tsai <thebrokentoaster@gmail.com>
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
What version of Go are you using (
go version
)?go version go1.6 linux/amd64
What operating system and processor architecture are you using (
go env
)?What did you do?
Try to run
x/net/http2
tests with 1.6What did you expect to see?
No error
What did you see instead?
It appears that golang.org/x/net/http2 ed0556cc888129faa06ff0ef3c65e0ce59c8b75c introduces this bug by attempting to use methods on
contextContext
which is a empty interface for 1.6 whereas for 1.7 it implementscontext.Context
.It seems like the simplest solution would be to make
contextContext
for 1.6 implementgolang.org/x/net/context.Context
.The text was updated successfully, but these errors were encountered: