Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

x/net/http2: pre-1.7 broken build #17286

Closed
rolandshoemaker opened this issue Sep 29, 2016 · 2 comments
Closed

x/net/http2: pre-1.7 broken build #17286

rolandshoemaker opened this issue Sep 29, 2016 · 2 comments

Comments

@rolandshoemaker
Copy link

@rolandshoemaker rolandshoemaker commented Sep 29, 2016

What version of Go are you using (go version)?

go version go1.6 linux/amd64

What operating system and processor architecture are you using (go env)?

GOARCH="amd64"
GOBIN=""
GOEXE=""
GOHOSTARCH="amd64"
GOHOSTOS="linux"
GOOS="linux"
GOPATH="/home/roland/gopath"
GORACE=""
GOROOT="/home/roland/go1.6"
GOTOOLDIR="/home/roland/go1.6/pkg/tool/linux_amd64"
GO15VENDOREXPERIMENT="1"
CC="gcc"
GOGCCFLAGS="-fPIC -m64 -pthread -fmessage-length=0"
CXX="g++"
CGO_ENABLED="1"

What did you do?

Try to run x/net/http2 tests with 1.6

What did you expect to see?

No error

What did you see instead?

# golang.org/x/net/http2
./transport.go:1853: ctx.Done undefined (type contextContext is interface with no methods)
./transport.go:1854: ctx.Err undefined (type contextContext is interface with no methods)
FAIL    golang.org/x/net/http2 [build failed]

It appears that golang.org/x/net/http2 ed0556cc888129faa06ff0ef3c65e0ce59c8b75c introduces this bug by attempting to use methods on contextContext which is a empty interface for 1.6 whereas for 1.7 it implements context.Context.

It seems like the simplest solution would be to make contextContext for 1.6 implement golang.org/x/net/context.Context.

@leadinglocally

This comment has been minimized.

Copy link

@leadinglocally leadinglocally commented Sep 30, 2016

This just started happening to me about 12 hours ago for no reason, on Go 1.7 !!!
How do i fix it?

@gopherbot

This comment has been minimized.

Copy link

@gopherbot gopherbot commented Sep 30, 2016

CL https://golang.org/cl/30070 mentions this issue.

@golang golang locked and limited conversation to collaborators Sep 30, 2017
c3mb0 pushed a commit to c3mb0/net that referenced this issue Apr 2, 2018
https://golang.org/cl/29965 adding ClientConn.Ping support introduced
a build failure on Go versions before 1.7.

Fixes golang/go#17286

Change-Id: Ibfb565e7d823a436e58dc833973d7bdb41b7de5a
Reviewed-on: https://go-review.googlesource.com/30071
Run-TryBot: Brad Fitzpatrick <bradfitz@golang.org>
TryBot-Result: Gobot Gobot <gobot@golang.org>
Reviewed-by: Joe Tsai <thebrokentoaster@gmail.com>
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Linked pull requests

Successfully merging a pull request may close this issue.

None yet
3 participants
You can’t perform that action at this time.