Join GitHub today
GitHub is home to over 50 million developers working together to host and review code, manage projects, and build software together.
Sign upGitHub is where the world builds software
Millions of developers and companies build, ship, and maintain their software on GitHub — the largest and most advanced development platform in the world.
syscall: Fsid.X__val not exported on s390x #17298
Comments
|
/cc @davecheney |
|
They should just not use the built-in syscall package. Also, that field is kinda disgusting and the comment is very encouraging: Fsid: uint64(uint64(stat.Fsid.X__val[1])<<32 | uint64(stat.Fsid.X__val[0])), // endianness?Do they even need that field? They don't seem to know what it even is. Deleting that line might be a better fix? |
|
CL https://golang.org/cl/30130 mentions this issue. |
|
You have to love the statfs man page on GNU/Linux: "Nobody knows what f_fsid is supposed to contain." But it does go on to say "The general idea is that f_fsid contains some random stuff such that the pair (f_fsid,ino) uniquely determines a file." |
Fixes golang/go#17298 This field is not present in all versions of the syscall package.
Fixes golang/go#17298 This field is not present in all versions of the syscall package.
Fixes golang/go#17298 This field is not present in all versions of the syscall package.
mkpost.go replaces all variables prefixed with 'X_' with '_' on s390x because most of them do not need to be exposed. X__val is being used by a third party library so it turns out we do need to expose it on s390x (it is already exposed on all other Linux architectures). Fixes #17298 and updates #18632. Change-Id: Ic03463229a5f75ca41a4a4b50300da4b4d892d45 Reviewed-on: https://go-review.googlesource.com/30130 Reviewed-by: Brad Fitzpatrick <bradfitz@golang.org>
Kubernetes recently added https://github.com/pkg/sftp as a dependency. The sftp package uses the
X__valmember in theFsidstruct which we currently replace with_on s390x using mkpost.go.The usage is here: https://github.com/pkg/sftp/blob/8197a2e580736b78d704be0fc47b2324c0591a32/server_statvfs_linux.go#L19.
Since this variable is used on other architectures we should expose it so that sftp will compile (although it may need an endianness fix too). I will send a CL.